From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753088AbdBJMne (ORCPT ); Fri, 10 Feb 2017 07:43:34 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:32564 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbdBJMnc (ORCPT ); Fri, 10 Feb 2017 07:43:32 -0500 Date: Fri, 10 Feb 2017 15:40:34 +0300 From: Dan Carpenter To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Alexander Alemayhu , devel@driverdev.osuosl.org, stefan.wahren@i2se.com, daniels@collabora.com, swarren@wwwdotorg.org, gregkh@linuxfoundation.org, lee@kernel.org, linux-kernel@vger.kernel.org, eric@anholt.net, mzoran@crowfest.net, linux-rpi-kernel@lists.infradead.org, popcornmix@gmail.com, shorne@gmail.com Subject: Re: [PATCH] staging: vc04_services: remove unused functions Message-ID: <20170210123928.GA4162@mwanda> References: <20170207115308.5208-1-alexander@alemayhu.com> <20170207120943.GC11154@mwanda> <78243491.gCbftNnyIb@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78243491.gCbftNnyIb@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote: > On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote: > > There is a bunch of vc04_services that we're still looking to merge in > > the near future. Please hold off deleting these until we are further > > along on that. > > > > More generally speaking, I'd like to see all the > -Wmissing-declarations/-Wmissing-prototypes warnings addressed > in the kernel and turn on that warning by default. > > If there are parts of vc04_services that are intentionally > left in place but currently unused, adding a declaration in the > header file with a comment should be sufficient to prevent it > from getting deleted or seeing bogus warnings. Yeah. That's true. There really isn't a good reason to have these warnings. regards, dan carpenter