From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752075AbdBJNfU (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 08:35:20 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:63051 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751274AbdBJNfQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 08:35:16 -0500
Date: Fri, 10 Feb 2017 07:22:29 -0600
From: Bin Liu <b-liu@ti.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
CC: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: usb: musb: add code comment for clarification
Message-ID: <20170210132229.GA3446@uda0271908>
Mail-Followup-To: Bin Liu <b-liu@ti.com>,
        "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20170210035654.GA11033@embeddedgus>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20170210035654.GA11033@embeddedgus>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2017 at 09:56:54PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
> 

Don't need 'drivers:' in the subject.

> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/usb/musb/musb_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 892088f..1aec986 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb *musb)
>  
>  			return;
>  		}
> +		/* FALLTHROUGH */

		/* fall through */
as in CodingStyle.

>  	case MUSB_QUIRK_A_DISCONNECT_19:
>  		if (musb->quirk_retries--) {
>  			musb_dbg(musb,
> -- 

Regards,
-Bin.