From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbdBJObb (ORCPT ); Fri, 10 Feb 2017 09:31:31 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60746 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbdBJOb3 (ORCPT ); Fri, 10 Feb 2017 09:31:29 -0500 Date: Fri, 10 Feb 2017 15:31:22 +0100 From: Greg KH To: "Luis R. Rodriguez" Cc: ming.lei@canonical.com, bp@alien8.de, wagi@monom.org, teg@jklm.no, mchehab@osg.samsung.com, zajec5@gmail.com, linux-kernel@vger.kernel.org, markivx@codeaurora.org, stephen.boyd@linaro.org, broonie@kernel.org, zohar@linux.vnet.ibm.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, luto@amacapital.net, fengguang.wu@intel.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, dhowells@redhat.com, bjorn.andersson@linaro.org, arend.vanspriel@broadcom.com, kvalo@codeaurora.org Subject: Re: [PATCH v5 0/2] firmware: add driver data API Message-ID: <20170210143122.GC18321@kroah.com> References: <20170112150244.12700-1-mcgrof@kernel.org> <20170207010854.30340-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170207010854.30340-1-mcgrof@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2017 at 05:08:52PM -0800, Luis R. Rodriguez wrote: > Greg, > > This v5 drops the driver porting examples in light of the fact simple > cases do not yet benefit from use of the newer API. The API is purposely > introduced bare bones so new features are easier to review. I am not going to review this until you actually convert some existing code, or do something with it. A test-module isn't proof that this is a good api or not. As it is, I can't add new apis with no users. sorry, greg k-h