From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbdBJPht (ORCPT ); Fri, 10 Feb 2017 10:37:49 -0500 Received: from 8bytes.org ([81.169.241.247]:56931 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdBJPh2 (ORCPT ); Fri, 10 Feb 2017 10:37:28 -0500 Date: Fri, 10 Feb 2017 16:36:08 +0100 From: Joerg Roedel To: Robin Murphy Cc: Will Deacon , Lorenzo Pieralisi , Alex Williamson , David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH 01/11] iommu: Rename iommu_get_instance() Message-ID: <20170210153608.GL7339@8bytes.org> References: <1486639981-32368-1-git-send-email-joro@8bytes.org> <1486639981-32368-2-git-send-email-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On Fri, Feb 10, 2017 at 02:12:54PM +0000, Robin Murphy wrote: > I'm really liking this series! Superficially it doesn't seem to break > anything on my Juno, but I'll give it a more thorough workout soon. Great, thanks for testing! Any problems in this series should show up on boot anyway. > > static inline const struct iommu_ops *of_iommu_get_ops(struct device_node *np) > > { > > - return iommu_get_instance(&np->fwnode); > > + return iommu_ops_from_fwnode(&np->fwnode); > > } > > Note that you've already got Lorenzo's patch queued to remove these of_ > wrappers. Yes, that was among the conflicts I resolved when merging this with the rest of the iommu-tree. Joerg