Re: [PATCH 03/11] iommu: Introduce new 'struct iommu_device'

kbuild test robot
2017-02-09T20:47:16Z

[-- Attachment #1: Type: text/plain, Size: 5463 bytes --]

Hi Joerg,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.10-rc7]
[cannot apply to iommu/next next-20170209]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/Let-IOMMU-core-know-about-individual-IOMMUs/20170209-233505
config: x86_64-randconfig-s0-02100256 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

Note: the linux-review/Joerg-Roedel/Let-IOMMU-core-know-about-individual-IOMMUs/20170209-233505 HEAD f657360e06e4d71eaae41b18f425745d6b737d22 builds fine.
It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

drivers/iommu/dmar.c: In function 'alloc_iommu':
>> drivers/iommu/dmar.c:1083:22: error: implicit declaration of function 'iommu_device_create' [-Werror=implicit-function-declaration]
iommu->iommu_dev = iommu_device_create(NULL, iommu,
^~~~~~~~~~~~~~~~~~~
>> drivers/iommu/dmar.c:1083:20: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
iommu->iommu_dev = iommu_device_create(NULL, iommu,
^
drivers/iommu/dmar.c: In function 'free_iommu':
>> drivers/iommu/dmar.c:1114:2: error: implicit declaration of function 'iommu_device_destroy' [-Werror=implicit-function-declaration]
iommu_device_destroy(iommu->iommu_dev);
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/iommu_device_create +1083 drivers/iommu/dmar.c

3a93c841 drivers/iommu/dmar.c Takao Indoh 2013-04-23 1077 if (sts & DMA_GSTS_QIES)
3a93c841 drivers/iommu/dmar.c Takao Indoh 2013-04-23 1078 iommu->gcmd |= DMA_GCMD_QIE;
3a93c841 drivers/iommu/dmar.c Takao Indoh 2013-04-23 1079
1f5b3c3f drivers/iommu/dmar.c Thomas Gleixner 2011-07-19 1080 raw_spin_lock_init(&iommu->register_lock);
e61d98d8 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1081
bc847454 drivers/iommu/dmar.c Joerg Roedel 2016-01-07 1082 if (intel_iommu_enabled) {
a5459cfe drivers/iommu/dmar.c Alex Williamson 2014-06-12 @1083 iommu->iommu_dev = iommu_device_create(NULL, iommu,
a5459cfe drivers/iommu/dmar.c Alex Williamson 2014-06-12 1084 intel_iommu_groups,
2439d4aa drivers/iommu/dmar.c Kees Cook 2015-07-24 1085 "%s", iommu->name);
a5459cfe drivers/iommu/dmar.c Alex Williamson 2014-06-12 1086
59203379 drivers/iommu/dmar.c Nicholas Krause 2016-01-04 1087 if (IS_ERR(iommu->iommu_dev)) {
59203379 drivers/iommu/dmar.c Nicholas Krause 2016-01-04 1088 err = PTR_ERR(iommu->iommu_dev);
59203379 drivers/iommu/dmar.c Nicholas Krause 2016-01-04 1089 goto err_unmap;
59203379 drivers/iommu/dmar.c Nicholas Krause 2016-01-04 1090 }
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1091
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1092 iommu_device_set_ops(&iommu->iommu, &intel_iommu_ops);
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1093
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1094 err = iommu_device_register(&iommu->iommu);
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1095 if (err)
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1096 goto err_unmap;
bc847454 drivers/iommu/dmar.c Joerg Roedel 2016-01-07 1097 }
bc847454 drivers/iommu/dmar.c Joerg Roedel 2016-01-07 1098
bc847454 drivers/iommu/dmar.c Joerg Roedel 2016-01-07 1099 drhd->iommu = iommu;
59203379 drivers/iommu/dmar.c Nicholas Krause 2016-01-04 1100
1886e8a9 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1101 return 0;
0815565a drivers/pci/dmar.c David Woodhouse 2009-08-04 1102
0815565a drivers/pci/dmar.c David Woodhouse 2009-08-04 1103 err_unmap:
6f5cf521 drivers/iommu/dmar.c Donald Dutile 2012-06-04 1104 unmap_iommu(iommu);
78d8e704 drivers/iommu/dmar.c Jiang Liu 2014-11-09 1105 error_free_seq_id:
78d8e704 drivers/iommu/dmar.c Jiang Liu 2014-11-09 1106 dmar_free_seq_id(iommu);
e61d98d8 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1107 error:
e61d98d8 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1108 kfree(iommu);
6f5cf521 drivers/iommu/dmar.c Donald Dutile 2012-06-04 1109 return err;
e61d98d8 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1110 }
e61d98d8 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1111
a868e6b7 drivers/iommu/dmar.c Jiang Liu 2014-01-06 1112 static void free_iommu(struct intel_iommu *iommu)
e61d98d8 drivers/pci/dmar.c Suresh Siddha 2008-07-10 1113 {
a5459cfe drivers/iommu/dmar.c Alex Williamson 2014-06-12 @1114 iommu_device_destroy(iommu->iommu_dev);
0d1395f4 drivers/iommu/dmar.c Joerg Roedel 2017-02-09 1115 iommu_device_unregister(&iommu->iommu);
a5459cfe drivers/iommu/dmar.c Alex Williamson 2014-06-12 1116
a868e6b7 drivers/iommu/dmar.c Jiang Liu 2014-01-06 1117 if (iommu->irq) {

:::::: The code at line 1083 was first introduced by commit
:::::: a5459cfece880e82778a60e6290ad6c0dd688a06 iommu/vt-d: Make use of IOMMU sysfs support

:::::: TO: Alex Williamson <alex.williamson@redhat.com>
:::::: CC: Joerg Roedel <jroedel@suse.de>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23560 bytes --]