From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbdBKBcX (ORCPT ); Fri, 10 Feb 2017 20:32:23 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:39483 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbdBKBcV (ORCPT ); Fri, 10 Feb 2017 20:32:21 -0500 Date: Fri, 10 Feb 2017 17:29:47 -0800 From: Guenter Roeck To: Qi Hou Cc: Peter Rosin , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Tracebacks in -next due to 'of: fix of_node leak caused in of_find_node_opts_by_path' Message-ID: <20170211012947.GA3102@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I see a number of tracebacks in test runs on qemu-next, all related to omap configurations. Here is an example: [ 0.000000] OF: ERROR: Bad of_node_put() on /ocp@68000000 [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 4.10.0-rc7-next-20170210 #1 [ 0.000000] Hardware name: Generic OMAP3-GP (Flattened Device Tree) [ 0.000000] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 0.000000] [] (show_stack) from [] (dump_stack+0x98/0xac) [ 0.000000] [] (dump_stack) from [] (kobject_release+0x48/0x7c) [ 0.000000] [] (kobject_release) from [] (__of_translate_address+0xb0/0x2cc) [ 0.000000] [] (__of_translate_address) from [] (__of_address_to_resource+0x28/0xb4) [ 0.000000] [] (__of_address_to_resource) from [] (of_address_to_resource+0x70/0x80) [ 0.000000] [] (of_address_to_resource) from [] (of_syscon_register+0x88/0x22c) [ 0.000000] [] (of_syscon_register) from [] (syscon_node_to_regmap+0x90/0x94) [ 0.000000] [] (syscon_node_to_regmap) from [] (omap_control_init+0x50/0xd8) [ 0.000000] [] (omap_control_init) from [] (omap_clk_init+0x3c/0x70) [ 0.000000] [] (omap_clk_init) from [] (__omap_sync32k_timer_init+0x20/0x2b4) [ 0.000000] [] (__omap_sync32k_timer_init) from [] (omap3_secure_sync32k_timer_init+0x3c/0x48) [ 0.000000] [] (omap3_secure_sync32k_timer_init) from [] (start_kernel+0x244/0x38c) [ 0.000000] [] (start_kernel) from [<8020807c>] (0x8020807c) [ 0.000000] Clocking rate (Crystal/Core/MPU): 26.0/332/500 MHz There are several such messages with different call paths. A log with all tracebacks is available at http://kerneltests.org/builders/qemu-arm-next/builds/627/steps/qemubuildcommand/logs/stdio Bisect points to commit 'of: fix of_node leak caused in of_find_node_opts_by_path'. Bisect log is attached. It is going to be interesting to learn if the patch introduces a problem or if it exposes one. Guenter --- # bad: [632571b1bee00494aef749512d9f3290dfba0ead] Add linux-next specific files for 20170210 # good: [d5adbfcd5f7bcc6fa58a41c5c5ada0e5c826ce2c] Linux 4.10-rc7 git bisect start 'HEAD' 'v4.10-rc7' # good: [0bd52e1bdcb050ad5bef5d8e93838d40fd44ac4b] Merge remote-tracking branch 'crypto/master' git bisect good 0bd52e1bdcb050ad5bef5d8e93838d40fd44ac4b # bad: [6431424e2adf1b48333f7bd54cd5be8fef3953d7] Merge remote-tracking branch 'tip/auto-latest' git bisect bad 6431424e2adf1b48333f7bd54cd5be8fef3953d7 # good: [37f0c524925ae1f8fb62e39b3330357b1dc090bf] Merge remote-tracking branch 'sound/for-next' git bisect good 37f0c524925ae1f8fb62e39b3330357b1dc090bf # good: [18e1b83f8219ccc8051e80384f90682739bf19c4] Merge remote-tracking branch 'mfd/for-mfd-next' git bisect good 18e1b83f8219ccc8051e80384f90682739bf19c4 # good: [7b844fd09215b87ed67ad69a3a5e09858f761dbb] Merge remote-tracking branch 'iommu/next' git bisect good 7b844fd09215b87ed67ad69a3a5e09858f761dbb # good: [11e891d2e00d4c9408c8a35712538d1003e3f549] Merge branch 'sched/core' git bisect good 11e891d2e00d4c9408c8a35712538d1003e3f549 # bad: [059a17407b8136363594f1d8c9fa53ac6ca6ac2a] Merge remote-tracking branch 'spi/for-next' git bisect bad 059a17407b8136363594f1d8c9fa53ac6ca6ac2a # good: [9cfda694080954aa2be700ccadcedd0c5c15277a] Merge remote-tracking branches 'spi/topic/mpc52xx', 'spi/topic/ppc4xx', 'spi/topic/pxa2xx', 'spi/topic/rockchip' and 'spi/topic/rspi' into spi-next git bisect good 9cfda694080954aa2be700ccadcedd0c5c15277a # good: [4b741bc35962ccf93b798a233512850c48c2646e] dt-bindings: net: remove reference to fixed link support git bisect good 4b741bc35962ccf93b798a233512850c48c2646e # good: [6160be71baba3dd80501c90ab44e0f17d5854721] Merge remote-tracking branches 'spi/topic/s3c64xx', 'spi/topic/sh-msiof', 'spi/topic/slave' and 'spi/topic/topcliff-pch' into spi-next git bisect good 6160be71baba3dd80501c90ab44e0f17d5854721 # good: [2a9bcff7f0d3883f5381f0fd8232990013002f92] Merge remote-tracking branch 'audit/next' git bisect good 2a9bcff7f0d3883f5381f0fd8232990013002f92 # bad: [e553f539f2af39db5e3b2c273cc1a22d34be49ad] of: make of_device_make_bus_id() static git bisect bad e553f539f2af39db5e3b2c273cc1a22d34be49ad # bad: [0549bde0fcb11a95773e7dc4121738b9e653abf4] of: fix of_node leak caused in of_find_node_opts_by_path git bisect bad 0549bde0fcb11a95773e7dc4121738b9e653abf4 # first bad commit: [0549bde0fcb11a95773e7dc4121738b9e653abf4] of: fix of_node leak caused in of_find_node_opts_by_path