[PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue
@ 2017-02-09 14:47 Arushi Singhal
  2017-02-10 14:08 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Arushi Singhal @ 2017-02-09 14:47 UTC (permalink / raw)
  To: forest; +Cc: gregkh, devel, linux-kernel

Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/vt6656/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h
index fcea6995fe26..62f18a959098 100644
--- a/drivers/staging/vt6656/channel.h
+++ b/drivers/staging/vt6656/channel.h
@@ -28,6 +28,6 @@
 
 #include "device.h"
 
-void vnt_init_bands(struct vnt_private *);
+void vnt_init_bands(struct vnt_private *priv);
 
 #endif  /* _CHANNEL_H_ */
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue
  2017-02-09 14:47 [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue Arushi Singhal
@ 2017-02-10 14:08 ` Greg KH
       [not found]   ` <CA+XqjF-+8p6uzzs-s1pWH39vg-UppnO-aCmEKQjqDeYd1c+nmA@mail.gmail.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2017-02-10 14:08 UTC (permalink / raw)
  To: Arushi Singhal; +Cc: forest, devel, linux-kernel

On Thu, Feb 09, 2017 at 08:17:56PM +0530, Arushi Singhal wrote:
> Function definitions arguments should also have an identifier name as
> reported by checkpatch.pl.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/vt6656/channel.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(

^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <CA+XqjF-+8p6uzzs-s1pWH39vg-UppnO-aCmEKQjqDeYd1c+nmA@mail.gmail.com>]

[parent not found: <CA+XqjF9ATSxEj4hYbE47ZswPokmGdCWgi7w6PWh5o9jw6_VYoQ@mail.gmail.com>]

[parent not found: <CA+XqjF-vMtXqNEi+B-2by+fuFXA4H+kCPypWK5pwQvNnKSidqw@mail.gmail.com>]

* Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue
       [not found]       ` <CA+XqjF-vMtXqNEi+B-2by+fuFXA4H+kCPypWK5pwQvNnKSidqw@mail.gmail.com>
@ 2017-02-11  6:58         ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-02-11  6:58 UTC (permalink / raw)
  To: Arushi Singhal; +Cc: linux-kernel, forest, devel

On Sat, Feb 11, 2017 at 07:48:35AM +0530, Arushi Singhal wrote:
> Hi
> Sorry Greg but how this not applying to your mailing list.

Your patch did not apply to my staging-next git tree.  Probably because
soemone else already did this same work before you did.  Try rebasing
your patch on my staging-next branch of staging.git on git.kernel.org
and see for yourself.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue
@ 2017-02-12 15:55 Arushi Singhal
  0 siblings, 0 replies; 4+ messages in thread
From: Arushi Singhal @ 2017-02-12 15:55 UTC (permalink / raw)
  To: forest; +Cc: gregkh, devel, linux-kernel

Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/vt6656/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h
index fcea6995fe26..62f18a959098 100644
--- a/drivers/staging/vt6656/channel.h
+++ b/drivers/staging/vt6656/channel.h
@@ -28,6 +28,6 @@
 
 #include "device.h"
 
-void vnt_init_bands(struct vnt_private *);
+void vnt_init_bands(struct vnt_private *priv);
 
 #endif  /* _CHANNEL_H_ */
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-12 15:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 14:47 [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue Arushi Singhal
2017-02-10 14:08 ` Greg KH
     [not found]   ` <CA+XqjF-+8p6uzzs-s1pWH39vg-UppnO-aCmEKQjqDeYd1c+nmA@mail.gmail.com>
     [not found]     ` <CA+XqjF9ATSxEj4hYbE47ZswPokmGdCWgi7w6PWh5o9jw6_VYoQ@mail.gmail.com>
     [not found]       ` <CA+XqjF-vMtXqNEi+B-2by+fuFXA4H+kCPypWK5pwQvNnKSidqw@mail.gmail.com>
2017-02-11  6:58         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-02-12 15:55 Arushi Singhal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox