From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbdBLMRK (ORCPT ); Sun, 12 Feb 2017 07:17:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37998 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbdBLMRJ (ORCPT ); Sun, 12 Feb 2017 07:17:09 -0500 Date: Sun, 12 Feb 2017 13:16:58 +0100 From: Greg Kroah-Hartman To: Man Choy Cc: mzoran@crowfest.net, devel@driverdev.osuosl.org, Stephen Warren , Lee Jones , linux-kernel@vger.kernel.org, Eric Anholt , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] bcm2835-audio: Fix checkpatch errors Message-ID: <20170212121658.GA19617@kroah.com> References: <1486845362-25086-1-git-send-email-manchoyy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486845362-25086-1-git-send-email-manchoyy@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote: > Fix following errors: > > ERROR: do not initialise statics to NULL > +static struct snd_card *g_card = NULL; > > ERROR: do not initialise statics to NULL > +static struct bcm2835_chip *g_chip = NULL; > > Signed-off-by: Man Choy > --- > drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c > index a84d74d..265fe55 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/bcm2835-audio/bcm2835.c > @@ -28,8 +28,8 @@ > * to debug if we run into issues > */ > > -static struct snd_card *g_card = NULL; > -static struct bcm2835_chip *g_chip = NULL; > +static struct snd_card *g_card; > +static struct bcm2835_chip *g_chip; > > static int snd_bcm2835_free(struct bcm2835_chip *chip) > { Someone sent this same fix in before you did, a few days ago. Be sure to always use the most up-to-date tree. sorry, greg k-h