From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbdBLMbf (ORCPT ); Sun, 12 Feb 2017 07:31:35 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38150 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbdBLMbe (ORCPT ); Sun, 12 Feb 2017 07:31:34 -0500 Date: Sun, 12 Feb 2017 13:31:23 +0100 From: Greg KH To: Derek Robson Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix Message-ID: <20170212123123.GA24415@kroah.com> References: <169a3591bfb127852190762ed8b4212edc5e58c1.1486804834.git.robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169a3591bfb127852190762ed8b4212edc5e58c1.1486804834.git.robsonde@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 11, 2017 at 10:57:28PM +1300, Derek Robson wrote: > Fixed style of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 +++++++++++++------------ > 1 file changed, 35 insertions(+), 34 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h > index c3aabbaac7ae..307ab45f528d 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h > @@ -86,38 +86,38 @@ typedef enum _CHNLOP{ > ((_pHTInfo)->ChnlOp > CHNLOP_NONE) ? TRUE : FALSE > > /* > -typedef union _HT_CAPABILITY{ > - u16 ShortData; > - u8 CharData[2]; > - struct > - { > - u16 AdvCoding:1; > - u16 ChlWidth:1; > - u16 MimoPwrSave:2; > - u16 GreenField:1; > - u16 ShortGI20Mhz:1; > - u16 ShortGI40Mhz:1; > - u16 STBC:1; > - u16 BeamForm:1; > - u16 DelayBA:1; > - u16 MaxAMSDUSize:1; > - u16 DssCCk:1; > - u16 PSMP:1; > - u16 Rsvd:3; > - }Field; > -}HT_CAPABILITY, *PHT_CAPABILITY; > - > -typedef union _HT_CAPABILITY_MACPARA{ > - u8 ShortData; > - u8 CharData[1]; > - struct > - { > - u8 MaxRxAMPDU:2; > - u8 MPDUDensity:2; > - u8 Rsvd:4; > - }Field; > -}HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA; > -*/ > + * typedef union _HT_CAPABILITY{ > + * u16 ShortData; > + * u8 CharData[2]; > + * struct > + * { > + * u16 AdvCoding:1; > + * u16 ChlWidth:1; > + * u16 MimoPwrSave:2; > + * u16 GreenField:1; > + * u16 ShortGI20Mhz:1; > + * u16 ShortGI40Mhz:1; > + * u16 STBC:1; > + * u16 BeamForm:1; > + * u16 DelayBA:1; > + * u16 MaxAMSDUSize:1; > + * u16 DssCCk:1; > + * u16 PSMP:1; > + * u16 Rsvd:3; > + * }Field; > + * }HT_CAPABILITY, *PHT_CAPABILITY; > + * > + * typedef union _HT_CAPABILITY_MACPARA{ > + * u8 ShortData; > + * u8 CharData[1]; > + * struct > + * { > + * u8 MaxRxAMPDU:2; > + * u8 MPDUDensity:2; > + * u8 Rsvd:4; > + * }Field; > + * }HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA; > + */ > > typedef enum _HT_ACTION{ > ACT_RECOMMAND_WIDTH = 0, I'll take this, but shouldn't we just delete these structures that are commented out? Same goes for other patches in this series. thanks, greg k-h