From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/15] staging: rtl8192u: Prefer using the BIT macro
Date: Sun, 12 Feb 2017 13:46:02 +0100 [thread overview]
Message-ID: <20170212124602.GA7093@kroah.com> (raw)
In-Reply-To: <20170212054758.GA23978@singhal-Inspiron-5558>
On Sun, Feb 12, 2017 at 11:17:58AM +0530, simran singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro as it's
> extensively used by other function in this driver.
>
> This was done with coccinelle:
> @@ int g; @@
>
> -(1 << g)
> +BIT(g)
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
ALWAYS test build your patches, otherwise you will get grumpy emails
from maintainers telling you to test build your patches!
Not good...
greg k-h
prev parent reply other threads:[~2017-02-12 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 5:47 [PATCH 13/15] staging: rtl8192u: Prefer using the BIT macro simran singhal
2017-02-12 12:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212124602.GA7093@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox