From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751318AbdBLMwz (ORCPT <rfc822;w@1wt.eu>);
        Sun, 12 Feb 2017 07:52:55 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:38412 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751194AbdBLMwy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 12 Feb 2017 07:52:54 -0500
Date: Sun, 12 Feb 2017 13:46:02 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/15] staging: rtl8192u: Prefer using the BIT macro
Message-ID: <20170212124602.GA7093@kroah.com>
References: <20170212054758.GA23978@singhal-Inspiron-5558>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170212054758.GA23978@singhal-Inspiron-5558>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Feb 12, 2017 at 11:17:58AM +0530, simran singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro as it's
> extensively used by other function in this driver.
> 
> This was done with coccinelle:
> @@ int g; @@
> 
> -(1 << g)
> +BIT(g)
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>

ALWAYS test build your patches, otherwise you will get grumpy emails
from maintainers telling you to test build your patches!

Not good...

greg k-h