From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ran Algawi <ran.algawi@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: media: bcm2048: Fixed an error
Date: Sun, 12 Feb 2017 13:28:14 -0800 [thread overview]
Message-ID: <20170212212814.GA14955@kroah.com> (raw)
In-Reply-To: <CAKg+OeRBUVwixkiWnS07=vYG3QHRUkuKxtRmZn5dGWQ0SZVRzA@mail.gmail.com>
On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote:
> Hello Greg,
> First, I appreciate you taking the time to educate me. I used the checkpatch
> script on the file I fixed and he reported the line as an error. Do you
> consider all checkpatch warnings/error/checks as coding style fixes?
The ones that refer to coding style issues, yes, that is what they are.
Sometimes the script points out other things that should be changed,
like octal values which is not an error in this case, but rather a
clarification.
And please turn html off in your email client, it gets rejected by the
mailing lists :)
thanks,
greg k-h
prev parent reply other threads:[~2017-02-12 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 22:41 [PATCH] Staging: media: bcm2048: Fixed an error Ran Algawi
2017-02-12 12:17 ` Greg KH
2017-02-12 21:26 ` Ran Algawi
[not found] ` <CAKg+OeRBUVwixkiWnS07=vYG3QHRUkuKxtRmZn5dGWQ0SZVRzA@mail.gmail.com>
2017-02-12 21:28 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212212814.GA14955@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ran.algawi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox