public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro
Date: Sun, 12 Feb 2017 14:18:21 -0800	[thread overview]
Message-ID: <20170212221821.GA20773@kroah.com> (raw)
In-Reply-To: <20170212215637.GA18517@singhal-Inspiron-5558>

On Mon, Feb 13, 2017 at 03:26:37AM +0530, simran singhal wrote:
> Fix the checkpatch.pl issue:
> CHECK: Prefer using the BIT macro replacing
> bit shifting on 1 with the BIT(x) macro.
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 ++++++++++++-------------
>  1 file changed, 70 insertions(+), 70 deletions(-)

Didn't you send this before?  If so, this should be a v2 patch, right?
And if so, please always say _what_ changed between versions, see
Documentation/SubmittingPatches for how to properly label this.

thanks,

greg k-h

  reply	other threads:[~2017-02-12 22:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-12 21:56 [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro simran singhal
2017-02-12 22:18 ` Greg KH [this message]
2017-02-13  9:15   ` SIMRAN SINGHAL
2017-02-13 11:49     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170212221821.GA20773@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox