From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583AbdBLWSX (ORCPT ); Sun, 12 Feb 2017 17:18:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48304 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbdBLWSW (ORCPT ); Sun, 12 Feb 2017 17:18:22 -0500 Date: Sun, 12 Feb 2017 14:18:21 -0800 From: Greg KH To: simran singhal Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro Message-ID: <20170212221821.GA20773@kroah.com> References: <20170212215637.GA18517@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170212215637.GA18517@singhal-Inspiron-5558> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 03:26:37AM +0530, simran singhal wrote: > Fix the checkpatch.pl issue: > CHECK: Prefer using the BIT macro replacing > bit shifting on 1 with the BIT(x) macro. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 ++++++++++++------------- > 1 file changed, 70 insertions(+), 70 deletions(-) Didn't you send this before? If so, this should be a v2 patch, right? And if so, please always say _what_ changed between versions, see Documentation/SubmittingPatches for how to properly label this. thanks, greg k-h