From: Jiri Olsa <jolsa@redhat.com>
To: Wang YanQing <udknight@gmail.com>,
acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
Date: Mon, 13 Feb 2017 09:19:18 +0100 [thread overview]
Message-ID: <20170213081918.GC11147@krava> (raw)
In-Reply-To: <20170212024655.GA15997@udknight>
On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote:
> Fix below compile error:
> CC util/scripting-engines/trace-event-perl.o
> In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
> from util/scripting-engines/trace-event-perl.c:31:
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
> dTHX; /* The function called below requires thread context */
> ^
> cc1: all warnings being treated as errors
>
> After digging perl5 repository, I find out that we will meet this compile error
> with perl from v5.21.1 to v5.25.4
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/util/scripting-engines/Build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
> index 6516e22..82d28c6 100644
> --- a/tools/perf/util/scripting-engines/Build
> +++ b/tools/perf/util/scripting-engines/Build
> @@ -1,6 +1,6 @@
> libperf-$(CONFIG_LIBPERL) += trace-event-perl.o
> libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
>
> -CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
> +CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
>
> CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
> --
> 1.8.5.6.2.g3d8a54e.dirty
>
next prev parent reply other threads:[~2017-02-13 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 2:46 [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions Wang YanQing
2017-02-13 8:19 ` Jiri Olsa [this message]
2017-02-13 16:14 ` Arnaldo Carvalho de Melo
2017-02-14 6:40 ` [tip:perf/core] perf scripting perl: " tip-bot for Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213081918.GC11147@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox