From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752428AbdBMITW (ORCPT ); Mon, 13 Feb 2017 03:19:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbdBMITV (ORCPT ); Mon, 13 Feb 2017 03:19:21 -0500 Date: Mon, 13 Feb 2017 09:19:18 +0100 From: Jiri Olsa To: Wang YanQing , acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions Message-ID: <20170213081918.GC11147@krava> References: <20170212024655.GA15997@udknight> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170212024655.GA15997@udknight> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 13 Feb 2017 08:19:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote: > Fix below compile error: > CC util/scripting-engines/trace-event-perl.o > In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0, > from util/scripting-engines/trace-event-perl.c:31: > /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow': > /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs] > dTHX; /* The function called below requires thread context */ > ^ > cc1: all warnings being treated as errors > > After digging perl5 repository, I find out that we will meet this compile error > with perl from v5.21.1 to v5.25.4 > > Signed-off-by: Wang YanQing Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/scripting-engines/Build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build > index 6516e22..82d28c6 100644 > --- a/tools/perf/util/scripting-engines/Build > +++ b/tools/perf/util/scripting-engines/Build > @@ -1,6 +1,6 @@ > libperf-$(CONFIG_LIBPERL) += trace-event-perl.o > libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o > > -CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default > +CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default > > CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow > -- > 1.8.5.6.2.g3d8a54e.dirty >