From: Peter Zijlstra <peterz@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, guohanjun@huawei.com,
Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH] sched/isolcpus: Show isolated cpu map
Date: Mon, 13 Feb 2017 13:06:50 +0100 [thread overview]
Message-ID: <20170213120650.GN6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1486979039-17874-1-git-send-email-wangkefeng.wang@huawei.com>
On Mon, Feb 13, 2017 at 05:43:59PM +0800, Kefeng Wang wrote:
> The commit a6e4491c682a ("sched/isolcpus: Output warning when the
> 'isolcpus=' kernel parameter is invalid") adds an error message
> when specified cpu bigger than nr_cpu_ids, but nr_cpumask_bits in
> cpulist_parse() could be nr_cpu_ids or NR_CPUS.
>
> eg, NR_CPUS=64, nr_cpu_ids=8 in ARM64, cpulist_parse() won't return
> -ERANGE if isolcpus=1-10;
>
But why does cpulist_parse() use nr_cpumask_bits, that seems to be the
problem, so why not look there?
next prev parent reply other threads:[~2017-02-13 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 9:43 [PATCH] sched/isolcpus: Show isolated cpu map Kefeng Wang
2017-02-13 12:06 ` Peter Zijlstra [this message]
2017-02-13 13:07 ` Kefeng Wang
2017-02-13 13:32 ` Peter Zijlstra
2017-02-14 1:53 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213120650.GN6515@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox