From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Byungchul Park <byungchul.park@lge.com>,
mingo@kernel.org, neilb@suse.de, nab@linux-iscsi.org,
viro@zeniv.linux.org.uk, ying.huang@intel.com, shli@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API
Date: Mon, 13 Feb 2017 16:52:30 +0100 [thread overview]
Message-ID: <20170213155229.GA1663@redhat.com> (raw)
In-Reply-To: <20170213100457.GL6515@twins.programming.kicks-ass.net>
On 02/13, Peter Zijlstra wrote:
>
> On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote:
> > + llist_for_each_entry(p, llist, wake_entry)
> > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf);
>
> I think this suffers the exact same problem the others did. After
> ttwu_do_activate() the llist entry can be reused, so doing list_next()
> after it is flaky.
llist_for_each_entry_safe() should work, I guess.
Oleg.
next prev parent reply other threads:[~2017-02-13 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 7:21 [PATCH v2 0/9] Don't reinvent the wheel but use existing llist API Byungchul Park
2017-02-13 7:21 ` [PATCH v2 1/9] llist: Provide a safe version for llist_for_each Byungchul Park
2017-02-13 7:36 ` Huang, Ying
2017-02-13 7:44 ` Byungchul Park
2017-02-13 7:52 ` Huang, Ying
2017-02-13 7:58 ` Byungchul Park
2017-02-14 6:44 ` Byungchul Park
2017-02-14 6:59 ` Huang, Ying
2017-02-13 7:21 ` [PATCH v2 2/9] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-02-13 7:21 ` [PATCH v2 3/9] raid5: " Byungchul Park
2017-02-13 7:21 ` [PATCH v2 4/9] vhost/scsi: " Byungchul Park
2017-02-13 7:21 ` [PATCH v2 5/9] fput: " Byungchul Park
2017-02-13 7:21 ` [PATCH v2 6/9] namespace.c: " Byungchul Park
2017-02-13 7:21 ` [PATCH v2 7/9] irq_work: " Byungchul Park
2017-02-13 7:21 ` [PATCH v2 8/9] sched: " Byungchul Park
2017-02-13 10:04 ` Peter Zijlstra
2017-02-13 15:52 ` Oleg Nesterov [this message]
2017-02-13 23:00 ` Byungchul Park
2017-02-13 22:59 ` Byungchul Park
2017-02-13 7:21 ` [PATCH v2 9/9] mm: " Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213155229.GA1663@redhat.com \
--to=oleg@redhat.com \
--cc=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nab@linux-iscsi.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=shli@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox