* [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
@ 2017-02-12 2:46 Wang YanQing
2017-02-13 8:19 ` Jiri Olsa
2017-02-14 6:40 ` [tip:perf/core] perf scripting perl: " tip-bot for Wang YanQing
0 siblings, 2 replies; 4+ messages in thread
From: Wang YanQing @ 2017-02-12 2:46 UTC (permalink / raw)
To: acme; +Cc: jolsa, mingo, linux-kernel
Fix below compile error:
CC util/scripting-engines/trace-event-perl.o
In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
from util/scripting-engines/trace-event-perl.c:31:
/usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
/usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
dTHX; /* The function called below requires thread context */
^
cc1: all warnings being treated as errors
After digging perl5 repository, I find out that we will meet this compile error
with perl from v5.21.1 to v5.25.4
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
tools/perf/util/scripting-engines/Build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
index 6516e22..82d28c6 100644
--- a/tools/perf/util/scripting-engines/Build
+++ b/tools/perf/util/scripting-engines/Build
@@ -1,6 +1,6 @@
libperf-$(CONFIG_LIBPERL) += trace-event-perl.o
libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
-CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
+CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
--
1.8.5.6.2.g3d8a54e.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
2017-02-12 2:46 [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions Wang YanQing
@ 2017-02-13 8:19 ` Jiri Olsa
2017-02-13 16:14 ` Arnaldo Carvalho de Melo
2017-02-14 6:40 ` [tip:perf/core] perf scripting perl: " tip-bot for Wang YanQing
1 sibling, 1 reply; 4+ messages in thread
From: Jiri Olsa @ 2017-02-13 8:19 UTC (permalink / raw)
To: Wang YanQing, acme, jolsa, mingo, linux-kernel
On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote:
> Fix below compile error:
> CC util/scripting-engines/trace-event-perl.o
> In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
> from util/scripting-engines/trace-event-perl.c:31:
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
> dTHX; /* The function called below requires thread context */
> ^
> cc1: all warnings being treated as errors
>
> After digging perl5 repository, I find out that we will meet this compile error
> with perl from v5.21.1 to v5.25.4
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/util/scripting-engines/Build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
> index 6516e22..82d28c6 100644
> --- a/tools/perf/util/scripting-engines/Build
> +++ b/tools/perf/util/scripting-engines/Build
> @@ -1,6 +1,6 @@
> libperf-$(CONFIG_LIBPERL) += trace-event-perl.o
> libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
>
> -CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
> +CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
>
> CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
> --
> 1.8.5.6.2.g3d8a54e.dirty
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
2017-02-13 8:19 ` Jiri Olsa
@ 2017-02-13 16:14 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-02-13 16:14 UTC (permalink / raw)
To: Jiri Olsa; +Cc: Wang YanQing, jolsa, mingo, linux-kernel
Em Mon, Feb 13, 2017 at 09:19:18AM +0100, Jiri Olsa escreveu:
> On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote:
> > Fix below compile error:
> > CC util/scripting-engines/trace-event-perl.o
> > In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
> > from util/scripting-engines/trace-event-perl.c:31:
> > /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
> > /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
> > dTHX; /* The function called below requires thread context */
> > ^
> > cc1: all warnings being treated as errors
> >
> > After digging perl5 repository, I find out that we will meet this compile error
> > with perl from v5.21.1 to v5.25.4
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf scripting perl: Fix compile error with some perl5 versions
2017-02-12 2:46 [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions Wang YanQing
2017-02-13 8:19 ` Jiri Olsa
@ 2017-02-14 6:40 ` tip-bot for Wang YanQing
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Wang YanQing @ 2017-02-14 6:40 UTC (permalink / raw)
To: linux-tip-commits; +Cc: jolsa, acme, mingo, udknight, tglx, linux-kernel, hpa
Commit-ID: d7dd112ea5cacf91ae72c0714c3b911eb6016fea
Gitweb: http://git.kernel.org/tip/d7dd112ea5cacf91ae72c0714c3b911eb6016fea
Author: Wang YanQing <udknight@gmail.com>
AuthorDate: Sun, 12 Feb 2017 10:46:55 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 13 Feb 2017 17:22:32 -0300
perf scripting perl: Fix compile error with some perl5 versions
Fix below compile error:
CC util/scripting-engines/trace-event-perl.o
In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
from util/scripting-engines/trace-event-perl.c:31:
/usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
/usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
dTHX; /* The function called below requires thread context */
^
cc1: all warnings being treated as errors
After digging perl5 repository, I find out that we will meet this
compile error with perl from v5.21.1 to v5.25.4
Signed-off-by: Wang YanQing <udknight@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170212024655.GA15997@udknight
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/scripting-engines/Build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
index 6516e22..82d28c6 100644
--- a/tools/perf/util/scripting-engines/Build
+++ b/tools/perf/util/scripting-engines/Build
@@ -1,6 +1,6 @@
libperf-$(CONFIG_LIBPERL) += trace-event-perl.o
libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
-CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
+CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-14 6:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-12 2:46 [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions Wang YanQing
2017-02-13 8:19 ` Jiri Olsa
2017-02-13 16:14 ` Arnaldo Carvalho de Melo
2017-02-14 6:40 ` [tip:perf/core] perf scripting perl: " tip-bot for Wang YanQing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox