From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbdBMQ03 (ORCPT ); Mon, 13 Feb 2017 11:26:29 -0500 Received: from mail.kernel.org ([198.145.29.136]:41464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdBMQ02 (ORCPT ); Mon, 13 Feb 2017 11:26:28 -0500 Date: Mon, 13 Feb 2017 13:26:22 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Namhyung Kim , Jiri Olsa , Linux Kernel Mailing List Subject: Re: [PATCH] building libtraceevent with clang Message-ID: <20170213162622.GC6473@kernel.org> References: <20170210170317.GA14313@kernel.org> <20170210141408.5eeb6e91@gandalf.local.home> <20170213162455.GB6473@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170213162455.GB6473@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Feb 13, 2017 at 01:24:55PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 10, 2017 at 02:14:08PM -0500, Steven Rostedt escreveu: > > On Fri, 10 Feb 2017 14:03:17 -0300 > > Arnaldo Carvalho de Melo wrote: > > > + case OLD_RINGBUF_TYPE_TIME_EXTEND: > > > + extend = read_4(kbuf, ptr); > > > + extend <<= TS_SHIFT; > > > + extend += delta; > > > + delta = extend; > > > + ptr += 4; > > > + /* Fall through */ > > > No, actually, the length should be zeroed here. > > > length = 0; > > > As the ptr is placed passed the metadata. At the end of this case > > statement, the ptr will be after the metadata. The length is > > to represent the length of the data that is part of the event. The > > index is the ptr - start_data + length. As there's no data to this type > > of event, it should be zero. > > > When I add length = 0, I get more events from my old 2.6.30 trace.dat > > file :-/ I'll have to update my tests. > > > Care to send another patch? > > I have this now in my tree, and since the patch is basically yours, I > just made myself the reporter and you the author, please ack. > > > commit 1fb82b6cba967afde11957099a9ef440cf8c2248 > Author: Steven Rostedt > Date: Mon Feb 13 13:18:29 2017 -0300 > > tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP > > A undefined value was being used for the OLD_RING_BUFFER_TYPE_TIME_STAMP > case entry, as the 'lenght' variable was not being initialized, fix it. > > Caught by the reporter when building tools/perf/ using clang, which emmitted > this warning: > > kbuffer-parse.c:312:7: warning: variable 'length' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case OLD_RINGBUF_TYPE_TIME_EXTEND: > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > kbuffer-parse.c:339:29: note: uninitialized use occurs here > kbuf->next = kbuf->index + length; > ^~~~~~ > kbuffer-parse.c:297:21: note: initialize the variable 'length' to silence this warning > unsigned int length; > ^ > = 0 > > Reported-by: Arnaldo Carvalho de Melo > Cc: Adrian Hunter > Cc: David Ahern > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Wang Nan > Link: http://lkml.kernel.org/r/20170210141408.5eeb6e91@gandalf.local.home > Signed-off-by: Steven Rostedt > > diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c > index 65984f1c2974..2009cb7d9675 100644 > --- a/tools/lib/traceevent/kbuffer-parse.c > +++ b/tools/lib/traceevent/kbuffer-parse.c > @@ -315,6 +315,7 @@ static unsigned int old_update_pointers(struct kbuffer *kbuf) > extend += delta; > delta = extend; > ptr += 4; > + lenght = 0; ouch, 'length' :-) clang provides a really nice error message: kbuffer-parse.c:318:3: error: use of undeclared identifier 'lenght'; did you mean 'length'? lenght = 0; ^~~~~~ length kbuffer-parse.c:297:15: note: 'length' declared here unsigned int length; ^ 1 error generated. I only had to test compile it :-) > break; > > case OLD_RINGBUF_TYPE_TIME_STAMP: >