From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Marc MERLIN <marc@merlins.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Please turn "Cannot use CONFIG_STACK_VALIDATION" into build error
Date: Mon, 13 Feb 2017 16:00:02 -0600 [thread overview]
Message-ID: <20170213220002.2hqnarjvx3ev2nl3@treble> (raw)
In-Reply-To: <20170213213132.GA28220@merlins.org>
On Mon, Feb 13, 2017 at 01:31:32PM -0800, Marc MERLIN wrote:
> Anyway, after not finding it in xconfig, I editted .config, and did:
> # CONFIG_STACK_VALIDATION is not set
> save .config
> and the next build re-enabled the option.
> That's what caught me by surprise. Did I do something wrong, or is there an
> issue there?
I really don't see how it would be possible for it to come back by
itself, as it's disabled by default, and no other options select it.
When I remove it, it stays disabled.
> > Ideally the same warning should be printed when building OOT modules.
> > I'll try to figure out if there's a way to do that it.
>
> This would help, although in that case you can even make the warning an
> error since objtool missing seems to be fatal?
It doesn't need to be fatal though. It should just be a warning and the
build should succeed, like it does when building the kernel.
--
Josh
next prev parent reply other threads:[~2017-02-13 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 8:07 Please turn "Cannot use CONFIG_STACK_VALIDATION" into build error Marc MERLIN
2017-02-13 18:41 ` Josh Poimboeuf
2017-02-13 21:31 ` Marc MERLIN
2017-02-13 22:00 ` Josh Poimboeuf [this message]
2017-02-13 22:05 ` Marc MERLIN
2017-02-13 23:08 ` Jessica Yu
2017-02-14 13:59 ` Josh Poimboeuf
2017-02-14 14:06 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213220002.2hqnarjvx3ev2nl3@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@merlins.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox