From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdBNIme (ORCPT ); Tue, 14 Feb 2017 03:42:34 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36604 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbdBNImc (ORCPT ); Tue, 14 Feb 2017 03:42:32 -0500 Date: Tue, 14 Feb 2017 09:42:26 +0100 From: Richard Cochran To: Dmitry Torokhov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes Message-ID: <20170214084226.GC8048@localhost.localdomain> References: <20170214035108.19622-1-dmitry.torokhov@gmail.com> <20170214035108.19622-3-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214035108.19622-3-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 07:51:07PM -0800, Dmitry Torokhov wrote: > Instead of creating selected attributes after the device is created (and > after userspace potentially seen uevent), lets use attribute group > is_visible() method to control which attributes are shown. This will allow > us to create all attributes (except "pins" group, which will be taken care > of later) before userspace gets notified about new ptp class device. At first glance, this patch and the next look like nice improvements. I don't futz around with sysfs code very often, and so may I ask how or whether you tested it? Thanks, Richard