From: "hch@lst.de" <hch@lst.de>
To: Dexuan Cui <decui@microsoft.com>
Cc: "hch@lst.de" <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"hare@suse.com" <hare@suse.com>, "hare@suse.de" <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jth@kernel.org" <jth@kernel.org>,
Nick Meier <Nick.Meier@microsoft.com>,
"Alex Ng (LIS)" <alexng@microsoft.com>,
Long Li <longli@microsoft.com>,
"Adrian Suhov (Cloudbase Solutions SRL)" <v-adsuho@microsoft.com>,
"Chris Valean (Cloudbase Solutions SRL)" <v-chvale@microsoft.com>
Subject: Re: Boot regression (was "Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements")
Date: Tue, 14 Feb 2017 14:47:36 +0100 [thread overview]
Message-ID: <20170214134736.GA19620@lst.de> (raw)
In-Reply-To: <MWHPR03MB2669B4FFC900983C8C357A77BF440@MWHPR03MB2669.namprd03.prod.outlook.com>
Hi Dexuan,
can you try the hack below for now? I disable the TUR call from
sd_check_events, which I think your VM is hanging on. The checks
it does on the sense data look a bit fishy, but so far I've not
identified a possible root cause.
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 40b4038c019e..1502e87c2be9 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1457,9 +1457,13 @@ static unsigned int sd_check_events(struct gendisk *disk, unsigned int clearing)
retval = -ENODEV;
if (scsi_block_when_processing_errors(sdp)) {
+#if 0
sshdr = kzalloc(sizeof(*sshdr), GFP_KERNEL);
retval = scsi_test_unit_ready(sdp, SD_TIMEOUT, SD_MAX_RETRIES,
sshdr);
+#else
+ retval = 0;
+#endif
}
/* failed to execute TUR, assume media not present */
next prev parent reply other threads:[~2017-02-14 13:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 9:48 [PATCH] genhd: Do not hold event lock when scheduling workqueue elements Hannes Reinecke
2017-01-31 0:31 ` Bart Van Assche
2017-01-31 16:15 ` Hannes Reinecke
2017-02-03 12:22 ` Dexuan Cui
2017-02-07 2:23 ` Dexuan Cui
2017-02-07 2:56 ` Bart Van Assche
2017-02-07 3:48 ` Dexuan Cui
2017-02-07 6:29 ` Dexuan Cui
2017-02-07 16:09 ` Jens Axboe
2017-02-08 10:48 ` Dexuan Cui
2017-02-08 17:43 ` Boot regression (was "Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements") Jens Axboe
2017-02-08 18:03 ` hch
2017-02-09 7:35 ` Dexuan Cui
2017-02-09 13:08 ` hch
2017-02-10 14:49 ` Dexuan Cui
2017-02-14 13:47 ` hch [this message]
2017-02-14 14:17 ` Dexuan Cui
2017-02-14 14:28 ` hch
2017-02-14 14:46 ` Dexuan Cui
2017-02-14 14:51 ` hch
2017-02-14 15:54 ` Dexuan Cui
2017-02-14 16:34 ` hch
2017-02-15 13:51 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214134736.GA19620@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=Nick.Meier@microsoft.com \
--cc=alexng@microsoft.com \
--cc=axboe@kernel.dk \
--cc=decui@microsoft.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=martin.petersen@oracle.com \
--cc=v-adsuho@microsoft.com \
--cc=v-chvale@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox