From: Greg KH <gregkh@linuxfoundation.org>
To: maomao xu <albert008.xu@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness
Date: Tue, 14 Feb 2017 09:18:25 -0800 [thread overview]
Message-ID: <20170214171825.GA1625@kroah.com> (raw)
In-Reply-To: <1487062390-26050-1-git-send-email-albert008.xu@gmail.com>
On Tue, Feb 14, 2017 at 04:53:10PM +0800, maomao xu wrote:
> Fixed sparse warnings about endianness. E.g.:
>
> warning: incorrect type in assignment (different base types)
Why are these lines indented?
> Signed-off-by: maomao xu <albert008.xu@gmail.com>
>
> diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
> index d868405..ffb9a3b 100644
> --- a/drivers/staging/fbtft/fbtft-io.c
> +++ b/drivers/staging/fbtft/fbtft-io.c
> @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
> src++;
> }
> tmp |= ((*src & 0x0100) ? 1 : 0);
> - *(u64 *)dst = cpu_to_be64(tmp);
> + *(__be64 *)dst = cpu_to_be64(tmp);
Really? That seems very odd. I need a maintainer's ack for this before
I can take it...
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-14 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 8:53 [PATCH]staging: fbtft: Fix sparse warnings about endianness maomao xu
2017-02-14 17:18 ` Greg KH [this message]
2017-02-14 18:57 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214171825.GA1625@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=albert008.xu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox