From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932082AbdBNRSc (ORCPT ); Tue, 14 Feb 2017 12:18:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56660 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754088AbdBNRSZ (ORCPT ); Tue, 14 Feb 2017 12:18:25 -0500 Date: Tue, 14 Feb 2017 09:18:25 -0800 From: Greg KH To: maomao xu Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness Message-ID: <20170214171825.GA1625@kroah.com> References: <1487062390-26050-1-git-send-email-albert008.xu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487062390-26050-1-git-send-email-albert008.xu@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 04:53:10PM +0800, maomao xu wrote: > Fixed sparse warnings about endianness. E.g.: > > warning: incorrect type in assignment (different base types) Why are these lines indented? > Signed-off-by: maomao xu > > diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c > index d868405..ffb9a3b 100644 > --- a/drivers/staging/fbtft/fbtft-io.c > +++ b/drivers/staging/fbtft/fbtft-io.c > @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len) > src++; > } > tmp |= ((*src & 0x0100) ? 1 : 0); > - *(u64 *)dst = cpu_to_be64(tmp); > + *(__be64 *)dst = cpu_to_be64(tmp); Really? That seems very odd. I need a maintainer's ack for this before I can take it... thanks, greg k-h