From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbdBNRcA (ORCPT ); Tue, 14 Feb 2017 12:32:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57428 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115AbdBNRbu (ORCPT ); Tue, 14 Feb 2017 12:31:50 -0500 Date: Tue, 14 Feb 2017 09:31:49 -0800 From: Greg KH To: "Gustavo A. R. Silva" Cc: Bin Liu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: musb: add code comment for clarification Message-ID: <20170214173149.GA20378@kroah.com> References: <20170210035654.GA11033@embeddedgus> <20170210132229.GA3446@uda0271908> <20170210185741.Horde.COi5P2LIGO-PnrSRuI3ipGV@gator4166.hostgator.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170210185741.Horde.COi5P2LIGO-PnrSRuI3ipGV@gator4166.hostgator.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote: > Add code comment to make it clear that the fall-through is intentional. > Read the link for more details: https://lkml.org/lkml/2017/2/9/292 > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/musb/musb_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 892088f..1aec986 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb > *musb) > > return; > } > + /* fall through */ > case MUSB_QUIRK_A_DISCONNECT_19: > if (musb->quirk_retries--) { > musb_dbg(musb, The tabs are all gone from this patch, and it's line-wrapped, making it impossible to be applied :( Can you please fix this and resend? thanks, greg k-h