From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbdBNRh1 (ORCPT ); Tue, 14 Feb 2017 12:37:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49364 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932191AbdBNRhV (ORCPT ); Tue, 14 Feb 2017 12:37:21 -0500 Date: Tue, 14 Feb 2017 18:37:17 +0100 From: Oleg Nesterov To: Aleksa Sarai Cc: Johannes Weiner , Ingo Molnar , Peter Zijlstra , Andrew Morton , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cyphar@cyphar.com Subject: Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Message-ID: <20170214173717.GA8913@redhat.com> References: <20170214150714.6195-1-asarai@suse.de> <20170214163005.GA2450@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 14 Feb 2017 17:37:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/15, Aleksa Sarai wrote: > > >This is an extra pointer to task_struct and more lines of code to > >accomplish the same thing. Why would we want to do that? > > I don't think it's more "actual" lines of code (I think the wrapping is > inflating the line number count), I too think it doesn't make sense to blow task_struct and the generated code. And to me this patch doesn't make the source code more clean. > but switching it means that it's more in > line with other queues in the kernel (it took me a bit to figure out what > was going on with oom_reaper_list beforehand). perhaps you can turn oom_reaper_list into llist_head then. This will also allow to remove oom_reaper_lock. Not sure this makes sense too. Oleg.