From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755410AbdBNSIx (ORCPT ); Tue, 14 Feb 2017 13:08:53 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755357AbdBNSIp (ORCPT ); Tue, 14 Feb 2017 13:08:45 -0500 Date: Tue, 14 Feb 2017 10:08:45 -0800 From: Greg KH To: Arushi Singhal Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues Message-ID: <20170214180845.GA8426@kroah.com> References: <20170214175620.GA7418@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214175620.GA7418@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 11:26:20PM +0530, Arushi Singhal wrote: > Macro argument 'a' may be better as '(a)' to avoid precedence issues as > reported by checkpatch.pl > > Signed-off-by: Arushi Singhal > --- > drivers/staging/fwserial/fwserial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c > index 41a49c8194e5..bdfc0a8c7af3 100644 > --- a/drivers/staging/fwserial/fwserial.c > +++ b/drivers/staging/fwserial/fwserial.c > @@ -98,7 +98,7 @@ struct fwtty_transaction { > }; > }; > > -#define to_device(a, b) (a->b) > +#define to_device((a), b) (a->b) Really? Why do we even have this macro at all? Can it just be removed? thanks, greg k-h