From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366AbdBNSNn (ORCPT ); Tue, 14 Feb 2017 13:13:43 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33233 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932227AbdBNSNc (ORCPT ); Tue, 14 Feb 2017 13:13:32 -0500 Date: Tue, 14 Feb 2017 19:13:27 +0100 From: Richard Cochran To: Dmitry Torokhov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes Message-ID: <20170214181327.GB25995@localhost.localdomain> References: <20170214035108.19622-1-dmitry.torokhov@gmail.com> <20170214035108.19622-3-dmitry.torokhov@gmail.com> <20170214084226.GC8048@localhost.localdomain> <20170214180747.GA4081@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214180747.GA4081@dtor-ws> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 10:07:47AM -0800, Dmitry Torokhov wrote: > > At first glance, this patch and the next look like nice improvements. > > I don't futz around with sysfs code very often, and so may I ask how > > or whether you tested it? > > I used the hack below. OK, thats fine. I'll be sure and test this here with my i210 which has real pins. Thanks, Richard