From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbdBNXfr (ORCPT ); Tue, 14 Feb 2017 18:35:47 -0500 Received: from customer-85-204-195-167.ip4.gigabit.dk ([85.204.195.167]:58364 "EHLO customer-2a00-7660-0ca7-0000-0000-0000-0000-0b1b.ip6.gigabit.dk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750992AbdBNXfp (ORCPT ); Tue, 14 Feb 2017 18:35:45 -0500 Date: Wed, 15 Feb 2017 00:35:39 +0100 From: Rask Ingemann Lambertsen To: Chen-Yu Tsai Cc: Mark Rutland , devicetree , Liam Girdwood , Rob Herring , linux-kernel , Mark Brown , Maxime Ripard , Lee Jones , linux-arm-kernel Subject: Re: [PATCH v6 5/5] ARM: dts: sun9i: Initial support for the Sunchip CX-A99 board Message-ID: <20170214233538.enkffjiw3kkfromu@localhost> References: <20170210085920.7l7gswm6yjuqgdfx@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 05:22:21PM +0800, Chen-Yu Tsai wrote: > On Fri, Feb 10, 2017 at 4:59 PM, Maxime Ripard > wrote: > > Hi, > > > > On Thu, Feb 09, 2017 at 12:34:06AM +0100, Rask Ingemann Lambertsen wrote: [...] > >> diff --git a/arch/arm/boot/dts/sun9i-a80-cx-a99.dts b/arch/arm/boot/dts/sun9i-a80-cx-a99.dts > >> new file mode 100644 > >> index 0000000..f5496d2 > >> --- /dev/null > >> +++ b/arch/arm/boot/dts/sun9i-a80-cx-a99.dts [...] > >> + pmic@745 { > >> + compatible = "x-powers,axp808", "x-powers,axp806"; > > As you mentioned elsewhere, they are not really compatible. > You should drop the latter compatible. The compatibility is good enough that it works fine with the driver that went into kernel 4.9 and 4.10. Using this device tree file, I have built and booted 4.9.9 and 4.10-rc7 kernels as per the instructions here; https://linux-sunxi.org/Sunchip_CX-A99#Linux_kernel Likewise any other AXP806 driver which doesn't touch the register at address 0xff will work fine. So, the disadvantage of removing the "x-powers,axp806" compatible is that it breaks on two kernel versions where it works fine with the compatible. What is the advantage of removing the "x-powers,axp806" compatible? As to touching the register at 0xff, it would be interesting to know more precisely what goes wrong. The symptom is these messages in the log: [ 3.209573] axp20x-rsb sunxi-rsb-745: AXP20x variant AXP806 found [ 3.210153] axp20x-rsb sunxi-rsb-745: Failed to set masks in 0x40: -5 [ 3.210178] axp20x-rsb sunxi-rsb-745: failed to add irq chip: -5 [ 3.210306] axp20x-rsb: probe of sunxi-rsb-745 failed with error -5 I haven't yet looked further into what happens at the RSB bus level. -- Rask Ingemann Lambertsen