From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751848AbdBOD5f (ORCPT ); Tue, 14 Feb 2017 22:57:35 -0500 Received: from gateway30.websitewelcome.com ([192.185.193.11]:33268 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdBOD5e (ORCPT ); Tue, 14 Feb 2017 22:57:34 -0500 X-Greylist: delayed 1500 seconds by postgrey-1.27 at vger.kernel.org; Tue, 14 Feb 2017 22:57:34 EST Date: Tue, 14 Feb 2017 21:10:52 -0600 From: "Gustavo A. R. Silva" To: gregkh@linuxfoundation.org, oneukum@suse.com, bjorn@mork.no, robert.foss@collabora.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Peter Senna Tschudin Subject: [PATCH] usb: class: remove logically dead code Message-ID: <20170215031052.GA5519@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.159.99 X-Exim-ID: 1cdpzZ-0006rM-9X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.159.99]:54880 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove logically dead code. 'cntr' is always equal to zero when the following line of code is executed: rv = cntr ? cntr : -EAGAIN; Addresses-Coverity-ID: 113227 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/class/cdc-wdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 0a63695..8fda45a 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -531,7 +531,7 @@ static ssize_t wdm_read i++; if (file->f_flags & O_NONBLOCK) { if (!test_bit(WDM_READ, &desc->flags)) { - rv = cntr ? cntr : -EAGAIN; + rv = -EAGAIN; goto err; } rv = 0; -- 2.5.0