From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751542AbdBOI7l (ORCPT ); Wed, 15 Feb 2017 03:59:41 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36382 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbdBOI7b (ORCPT ); Wed, 15 Feb 2017 03:59:31 -0500 Date: Wed, 15 Feb 2017 09:59:26 +0100 From: Peter Senna Tschudin To: "Gustavo A. R. Silva" Cc: gregkh@linuxfoundation.org, oneukum@suse.com, bjorn@mork.no, robert.foss@collabora.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: class: remove logically dead code Message-ID: <20170215085926.GA24915@gmail.com> References: <20170215031052.GA5519@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215031052.GA5519@embeddedgus> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 09:10:52PM -0600, Gustavo A. R. Silva wrote: > Remove logically dead code. > 'cntr' is always equal to zero when the following line of code is executed: > rv = cntr ? cntr : -EAGAIN; > > Addresses-Coverity-ID: 113227 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Peter Senna Tschudin > --- > drivers/usb/class/cdc-wdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c > index 0a63695..8fda45a 100644 > --- a/drivers/usb/class/cdc-wdm.c > +++ b/drivers/usb/class/cdc-wdm.c > @@ -531,7 +531,7 @@ static ssize_t wdm_read > i++; > if (file->f_flags & O_NONBLOCK) { > if (!test_bit(WDM_READ, &desc->flags)) { > - rv = cntr ? cntr : -EAGAIN; > + rv = -EAGAIN; > goto err; > } > rv = 0; > -- > 2.5.0 >