From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdBOK7E (ORCPT ); Wed, 15 Feb 2017 05:59:04 -0500 Received: from mail-ve1eur01on0058.outbound.protection.outlook.com ([104.47.1.58]:5617 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751462AbdBOK7B (ORCPT ); Wed, 15 Feb 2017 05:59:01 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mark.Rutland@arm.com; Date: Wed, 15 Feb 2017 10:58:51 +0000 From: Mark Rutland To: Arnd Bergmann CC: Catalin Marinas , Will Deacon , Ingo Molnar , Ard Biesheuvel , Steven Rostedt , Josh Poimboeuf , , , Subject: Re: [PATCH] arm64: include asm/assembler.h in entry-ftrace.S Message-ID: <20170215105851.GC31733@leverpostej> References: <20170214213314.2910910-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170214213314.2910910-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: HE1PR0701CA0046.eurprd07.prod.outlook.com (10.168.191.14) To DB6PR0802MB2390.eurprd08.prod.outlook.com (10.172.250.143) X-MS-Office365-Filtering-Correlation-Id: 485d913e-0db0-486c-5d00-08d45591a48f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DB6PR0802MB2390; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;3:36dwq2vwXYDqD71yHl3OlpVp3AZN5+kVhqw1VeqxrqOyhWptNUlUvU9LhWo3uS1slSScfg7oZREzNllV5CXimQpKESKB9RUoQxH61sR732c5XGDVZbH2rswCfFsF5yEU0ejN69tyb/XwODTcHTGtKaPkVJSF0HVdSOqwiq5oKlVHyNidp2RvlVC5wwkn288QHAknkLvFc88D99wvZcDbiMOCqhB5olhnS9mfYKfeu2UqkaAU25nnt7vwjqhpJHpuhGzsWYNzzAWjk6jYhGheeChNt96igd8SBS27TTUOeFA=;25:ETIowwWV74BvGvEV9wD6FfH3HBeL1JFu+PfftEDi72nEWiOQzKQ33KDx/wINgWblHB6bUzsUn0O0MnMRTfPEjn9FuSJECtUkUalYGd64N41ywHYPDuTgIYFNlgAI57aT+bl4bRzb+X4/cXj8bb/SgjvFx9Ji0JjKeijZmkcF8DDch76j0hg522Ak71C7cThC5sN3dz6CjdeKf83xYsCWn/SzLaMl1s0eSwyKDSgMSmG1FMVESV41OtyKMExzJeD+DyuXUiDZ8ihVXXPoD0vD3dlC86txSm20qJXKhYqJu5hlH8PGmnkybK1b6e6rpc26cv57FuAOawgU1cbYSpDHDVRCp/ykTZw7+j4p3++122/x6aWe50Ep3837ZKNZGITqjnLJxjjynfiv6lC1XFgFK7DRWPQsRlNhGYIFPVasM2ptPdya+A/M3POU9NSxVblIhgkrQ/731uaE2sgqY6rHSg== X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;31:qmREu5r5UAbje7mfWFAcU0Sc7ZnsCGJIbfZRAqfS2bL0dyOvbPzuzz7nsJrlfP6/JZ8MNcIxpXO0s/0E2LNGbdwVnG3ofYephO/qt3tZe9T1h3nr1syTJnFXVz8SYIv7POkE5USyYHLMXIyrJblWz7YxAQaM6O68p60mkRpU73+VdW9RYJr0SzRhZrLfw4ojEsSWoOasxA8XUpFYDrHFkEFL3sddywHd38N3yZEak4w=;20:kGw1Ypt5F/UTOt04zpYIVonHZBKkzSVN6ujMqzA8hmsjAFAQ9xsoVTJee0aVQVymIik0ixZws5mPw3VbZeWcGiEMs7U9EUreK1rFryf5lQdUevPMjbu1TSOS6ht3w5OBk6EazcpzdZUzumtzQMNqW89FYD6KpLeUmc48zyxIKC8= NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558025)(6072148);SRVR:DB6PR0802MB2390;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2390; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;4:vB5qgmhb3Gr+S6unNLcLaGG78O9dyo1X6H2QaW67Pr5NoML9eBOmaX0puHr76AvvgN9Kfd+t5MSLaquKmJr5JmOJMbQwWVY21W+plNtpn2xjnAHEP70OLjU41G7IN+SFIAhVzvLKLtw7W0uf4FowI5NDq9Zis4VgqEmK+qQ6+47A3gaZ/CGXx6POe3UQRF03rMQtyzgi0dfC2sIhobdY/oHEmRS+Ai3a30D/gnVSRSn0FRy2XFwkvOLdtUciwTlxIb+QlaCfbGHn7O7aMn9mLrZcGQeiBzuKz/uP7XnYBfo92aJWuNGgHQ4evI3MJlP+/Rw0MOvjnp9NCuaERct+CfFKOD/rhDbYsaMhvDIFiX5zoG4FqJvxbXQ+L2Kzmim+fFCLJNlFMRymwlTlzSHUwVqk8/8rTyUjFpGYZb6B+qJz3CaKHWTX5jUkLr5+1Z5D2GQ3I0o2DKNVshUznas501JxrlORwfHcW3BK5rp1yyAExtKuHi3OpVDib3MdLwLtm17m3WYgf9PlHBugUrktPbWL/XIqSYoxKJPrkHMifTNEbhKretPu/tevG4jKdZcCSpC3u+Zj0OqiP95HRIMSyl380B0IX87BzENfF5n7gwrahYS9PFAm/2r4IDFp5mWryZKaTHYXX+i/Rmbzy2k3ITbjKaBVtF0ympzudviMNas= X-Forefront-PRVS: 021975AE46 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39410400002)(39850400002)(39860400002)(39450400003)(39840400002)(189002)(199003)(24454002)(68736007)(33716001)(81156014)(25786008)(81166006)(5660300001)(2906002)(54906002)(55016002)(9686003)(42186005)(229853002)(97736004)(50466002)(4001350100001)(38730400002)(8676002)(189998001)(389900002)(110136004)(46406003)(6246003)(7736002)(83506001)(305945005)(47776003)(92566002)(66066001)(6496005)(97756001)(86362001)(6916009)(33656002)(2950100002)(53936002)(50986999)(76176999)(105586002)(54356999)(6116002)(1076002)(23726003)(4326007)(101416001)(6666003)(106356001)(3846002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2390;H:leverpostej;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0802MB2390;23:mX2tbLYxGUqGvjQy/NWO/02dZs8TVUAN2bHmVkt?= =?us-ascii?Q?ptk9sJeClFGT+ZxEK72h32xEuFuNFablwHZ/iJSkybA30s/gzgJ+G4KoScj0?= =?us-ascii?Q?mvBE2Aua6RNLdeynyv4sJesrW9dabW17rgze4Ws9UbBdYp1K8X/2uCWCwsMB?= =?us-ascii?Q?pXuiwQClDZpH0IbO2RU69ufd1mETn8z0S9C77h2B7Jc9uwlCZAsDgLvxOrcr?= =?us-ascii?Q?2Ps6dqsqTpAUvKbU47IX5Ybd9TI8L2lCZ3lzF2eAUbcpQ938oBofXgk3/xV9?= =?us-ascii?Q?KvotbzEP8hMdjbJhwBJBVV/gH3jBDuzoZS5P+ymtHz2FdsvRu9vEM7j0u/lO?= =?us-ascii?Q?G6EO3Ii3FGuiXh/oT1kmP6duEJnJqJ7izFymmc21yOo5NiYkd+OLe4YLzOED?= =?us-ascii?Q?q4tfiVP/7x51SdVgsfRP+sfduq0flfKfuzxI6/ZQ1MS/ZolLL4CYhSzb11PB?= =?us-ascii?Q?uP8uD3X2rd4IHlagqKlRdIZvTPXzO7zqgHa4ilxPZz7t+PWS9SOtboAvbtfQ?= =?us-ascii?Q?Hh1LZ9ixJrT+3Fn3kdWAAaqLyykFfe/qi72nKpyxtHngAL9dKAzg2wrhQzJB?= =?us-ascii?Q?jQveEzcy5eozw6T+0ceGcXCpRJJF4vluI6ZEFY64mgGfFwocpBDV8YeuF94Q?= =?us-ascii?Q?nTtxqsjqyJ186o7dqifFJpsrghcpF8K0IJDwYNvuXXKnmELcfUZiG88Fqlyo?= =?us-ascii?Q?Y9tFiVJFR/WYF5MTkT6bZV/JTAc9Fmzwbg4Ilxdbv5IPwq19PE0P9KhPPZgi?= =?us-ascii?Q?K/k5VOD7UGeHMYnh9IsIMFfqJiNwKODmHsVS8AAd1IPYb50sym8cQuab3s3e?= =?us-ascii?Q?8vRFlHfwSMldi+zEWqvXdTnpHJ1r67J6sHBURBmksSz3Rqw9iuX24IzbzY7C?= =?us-ascii?Q?FjN+1BqizDkuEAsZMmJYa5ibT3JeFRdHX3v7S5IgTeO3EB4Ss7QstESGYXed?= =?us-ascii?Q?pOVUslc/jbyCHpGmca8LdHU9x7yiw9uj4Uf1m52MtULJurvg0asleUV2uSE1?= =?us-ascii?Q?Wi6spvhqUp0a+EYwwscWjaxr7XtGQ3A0luSIOaq+iwg1z6wcKy3LH9l3BYKO?= =?us-ascii?Q?EUwp+OrBfkUYPKcVlmJRSL87CWDN2QJgcjqAoBEtH3uRl3nWcSdqti8Si9TV?= =?us-ascii?Q?8iwYRTZ9PXjaDJ8F9isYuBovz9PdUjzcQu/lKOEDmNo/NMMYhU7GSIgilbpQ?= =?us-ascii?Q?pr1PtzEnafRHOHOkCTwJ4J9eTuPHl5lzq3japuoPxiOhm20T9sqaO2vhdwgu?= =?us-ascii?Q?KMZaOGQcN63Xbl2SGRlI+lZVOVF2jZqvpQM0okXWSvfj7JPKRGvyBYn3RzDw?= =?us-ascii?Q?ygWWgrDnklOqzHlTwU4XQ8aG/lwjrRHK+mZEmX0T/yohYuwBI77Qy3UtIp1G?= =?us-ascii?Q?MOerP+Qxz8eAoVSNVplNsinfpGucb5GO3n5257Eb+bs0kD+0ShKuxWk+c4xy?= =?us-ascii?Q?bVWocM+3e1A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;6:HUPThR5eayf+HNTQgHDPF8a369GZMgIzzI6C0Kvz335JPH/wX10I379LTL2x47JVvH57A/mWeTkSUBZMQHXIW9w/+4R0axht4M3sNzeKlnIO4qLWbV/8Jobttz8SJ11EnXBhMNXBsFNcUUPTzNrKyjEnIdVnotj/hYUKbVOR2LlWWepns6JYbdICltewcSItHCnUixbrqbJD7/fW/B8+HeBVuUqE4w9icXFmGoGaUgFNlPcw+q75ipxQsKMS0sFROe3Jl00iV7TViBmMSDVkYEEyxPkiB6bnOKo3goAxWmCuTuVsdFeZzmXKSyqA18sBbwfo0UyAtoYuIMxIXwn35N2iCdi8NbOwMGbm8RHEvK469ORxPXgUKqCxmePwfoB+A3wY6woOAh/mIriZehK0elLNFfdt5SSyqoqzxwocUag=;5:rtVh7/qSlETuTbWo27rMs8H+L5YcDMU8jE/ZQYb5rVMhTbCc+EhZh4zaB7AsCtTImAOa5jv8wKIF6BYtETVKybU7oRw/bXeOLzM7sdeqZPOP7KdUXbmgVDxiFf4SN3pe68GKQVWzdpZG6bhLcVejzA==;24:rqfFLOOdmwRtoV2iY/qppjhrJUfRa9ytoSir430TX98/dx4O1d0OmDursZkZI3+btEndBj6xq+zkigEkFCttScCMehjgMqiXFZqDZK/zlGk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;7:sqAqLfCQ/cTMrXPSx+TsIZXEMkr5Qz0UGtA3+MM21/W7UhK99/ttJwn6RgQv/n6+9Jo+mF1verMsPT9o75cTqFl7kbvEmiozWXyKd2krNTdtjlt2f/EzojgnHJdOXSqo/d143IHBpzZl3d+1lyLidE22UMkTCdsHREqW3E+6YUUrbUcSdKpscUDRcRnfL37TUexFIY5jG/xyJfnj4PYSA13Ylm7gDl5hXW/c1rhVLFWz98ao+q8Th/7GK3jMBGXOPof8R6T4TRrZef01E58gfj33ZBizLMADR0tnASObSQC9AxMoE0vpgUD1W7DLt3LawZumbzHszr4ConI6h4tQHl7Peq4m3PAvUwhttEGcKi9sObpvRWp0y/TcJAPUgQxwXvQo8okALoI0wRnPX2PVGav2+99lJaK7c/LViZugIKCIrb1reUE1eftjSjE3Z2vNSHleLtg2400FLKchFY8syQGw5jHhRZRYThsuEIiTLCmVuxboz+PokH61RUwH661QGJn3Qot5TnumJ4Z8tSIgCg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2017 10:58:57.3470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2390 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 10:32:58PM +0100, Arnd Bergmann wrote: > In a randconfig build I ran into this build error: > > arch/arm64/kernel/entry-ftrace.S: Assembler messages: > arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function' > > The macro is defined in asm/assembler.h, so we should include that file. > > Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l") > Signed-off-by: Arnd Bergmann My bad; thanks for fixing this. Acked-by: Mark Rutland Thanks, Mark. > --- > arch/arm64/kernel/entry-ftrace.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S > index 8f1905b795f3..e1be42e11ff5 100644 > --- a/arch/arm64/kernel/entry-ftrace.S > +++ b/arch/arm64/kernel/entry-ftrace.S > @@ -10,6 +10,7 @@ > */ > > #include > +#include > #include > #include > > -- > 2.9.0 >