From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751894AbdBOLUG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Feb 2017 06:20:06 -0500
Received: from mail-wr0-f193.google.com ([209.85.128.193]:33919 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751618AbdBOLUE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Feb 2017 06:20:04 -0500
Date: Wed, 15 Feb 2017 11:20:01 +0000
From: Jamie Iles <jamie@jamieiles.com>
To: Hoan Tran <hotran@apm.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Weike Chen <alvin.chen@intel.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Loc Ho <lho@apm.com>, Duc Dang <dhdang@apm.com>
Subject: Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene
 SoC
Message-ID: <20170215112001.GA30801@page>
References: <1485891838-27093-1-git-send-email-hotran@apm.com>
 <CACRpkdZw-QLOeiPqSRaEJ+mGGDwi5fh9B1uenPxQGBtTwj+cuw@mail.gmail.com>
 <20170213093834.GA16603@page>
 <CAFHUOYxxygE4ouZySwvLr3=xBPSATk0XqpMDVL=EZcciV7FNRA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFHUOYxxygE4ouZySwvLr3=xBPSATk0XqpMDVL=EZcciV7FNRA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hoan,

On Tue, Feb 14, 2017 at 05:22:09PM -0800, Hoan Tran wrote:
> Hi Linus, Jamie and all,
> 
> Do you have any comments on this patch?

I think that the CONFIG_ACPI ifdef can be removed to clean it up - 
acpi_match_device() returns NULL for !CONFIG_ACPI.

Other than that, looks good to me.

Jamie