From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbdBOLib (ORCPT ); Wed, 15 Feb 2017 06:38:31 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36304 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdBOLia (ORCPT ); Wed, 15 Feb 2017 06:38:30 -0500 Date: Wed, 15 Feb 2017 11:38:22 +0000 From: Sudip Mukherjee To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] m32r: mm: fix build warning Message-ID: <20170215113822.GA10057@sudip-tp> References: <1487109945-5342-1-git-send-email-sudipm.mukherjee@gmail.com> <20170214141551.93d31680b42e255b7c604e51@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214141551.93d31680b42e255b7c604e51@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 02:15:51PM -0800, Andrew Morton wrote: > On Tue, 14 Feb 2017 22:05:45 +0000 Sudip Mukherjee wrote: > > > The build of m32r was giving warning: > > mm/pgtable-generic.c: In function 'ptep_clear_flush': > > mm/pgtable-generic.c:76:20: warning: > > unused variable 'mm' [-Wunused-variable] > > > > The implementation of ptep_get_and_clear() and pte_accessible() > > does not use 'mm'. > > That's because ptep_get_and_clear() and pte_accessible() are > implemented as macros. If they were (static inline) C functions then > this warning wouldn't occur. All the other architectures get this > right. oops.. sorry.. usually I will check all the other arch before sending a patch but missed it this time. Will investigate further today and send you a modified patch. Regards Sudip