From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdBOMlK (ORCPT ); Wed, 15 Feb 2017 07:41:10 -0500 Received: from mail.kernel.org ([198.145.29.136]:46296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbdBOMlJ (ORCPT ); Wed, 15 Feb 2017 07:41:09 -0500 Date: Wed, 15 Feb 2017 09:41:02 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , Namhyung Kim , Wang Nan , Linux Kernel Mailing List Subject: perf bison: clang points out: error: conflicting types for 'parse_events_error' always evaluate to 'true' Message-ID: <20170215124102.GA4020@kernel.org> References: <20170214182435.GD4458@kernel.org> <20170215105056.GB8207@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215105056.GB8207@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 15, 2017 at 11:50:56AM +0100, Jiri Olsa escreveu: > On Tue, Feb 14, 2017 at 03:24:35PM -0300, Arnaldo Carvalho de Melo wrote: > > util/pmu.c:948:28: error: address of array 'alias->unit' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] > > if ((info->unit && alias->unit) || > > ~~ ~~~~~~~^~~~ > > util/pmu.c:953:13: error: address of array 'alias->unit' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] > > if (alias->unit) > > ~~ ~~~~~~~^~~~ > > 2 errors generated. > > > > > > So, is this test about having something on that alias->unit array? I.e. > > should this suffice? > > yep, that seems right.. good catch Thanks, adding your Acked-by then, ok? How about this other one: CC /tmp/build/perf/util/trace-event-info.o util/parse-events.y:699:6: error: conflicting types for 'parse_events_error' void parse_events_error(YYLTYPE *loc, void *data, ^ /tmp/build/perf/util/parse-events-bison.c:2224:7: note: previous implicit declaration is here yyerror (&yylloc, _data, scanner, YY_("syntax error")); ^ /tmp/build/perf/util/parse-events-bison.c:65:25: note: expanded from macro 'yyerror' #define yyerror parse_events_error ^ 1 error generated.