From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbdBOUcK (ORCPT ); Wed, 15 Feb 2017 15:32:10 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:31232 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdBOUbq (ORCPT ); Wed, 15 Feb 2017 15:31:46 -0500 Date: Wed, 15 Feb 2017 23:31:16 +0300 From: Dan Carpenter To: Arnd Bergmann Cc: maomao xu , devel@driverdev.osuosl.org, gregkh , Peter P Waskiewicz Jr , Linux Kernel Mailing List , Rashika Kheria , singhalsimran0@gmail.com Subject: Re: [PATCH] staging: rtl8192u: Fix warnings about endianness Message-ID: <20170215203115.GC4108@mwanda> References: <1487145261-7541-1-git-send-email-albert008.xu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 09:33:15AM +0100, Arnd Bergmann wrote: > I see the same warning was addressed very differently in 99277c1f9962 > ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in > rtllib_crypt_tkip.c"), which was for a close relative of that driver. > > Only one of the two approaches (at most) can be correct, so we > regardless of your patch either rtl8192e or rtl8192u is broken on > big-endian machines. 99277c1f9962 ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in rtllib_crypt_tkip.c") is obviously broken. Can you send a patch to change it back? regards, dan carpenter