public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Juri Lelli <juri.lelli@arm.com>,
	peterz@infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, juri.lelli@gmail.com,
	kernel-team@lge.com, Luca Abeni <luca.abeni@santannapisa.it>
Subject: Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task()
Date: Wed, 15 Feb 2017 21:31:50 -0500	[thread overview]
Message-ID: <20170215213150.4aa1e10d@grimm.local.home> (raw)
In-Reply-To: <20170216021758.GS16086@X58A-UD3R>

On Thu, 16 Feb 2017 11:17:58 +0900
Byungchul Park <byungchul.park@lge.com> wrote:


> Juri and steven, thank you very much for reviewing it.
> 
> I'm not sure and familiar with... Should I add your 'reviewed by' into
> my patches by myself?
> 

No, it's the maintainer's job to add these tags when they take your
patch. If you were to resend the patch because of a minor change
(something a reviewer told you to make but still gave you their
reviewed-by tag), then you could add it. Or if you have a patch series
and resend a new series, you can add the reviewed-by tags to the
patches that were not changed. But if you were to change a patch, then
you need to ask the reviewer to give their tag again, because they need
to review the changes made before their tag should go on it.

Make sense?

-- Steve

  reply	other threads:[~2017-02-16  2:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15  5:11 [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task() Byungchul Park
2017-02-15  5:22 ` Byungchul Park
2017-02-15 10:47 ` Juri Lelli
2017-02-15 11:37   ` Peter Zijlstra
2017-02-15 14:25   ` Steven Rostedt
2017-02-15 14:45     ` Juri Lelli
2017-02-15 14:55       ` Steven Rostedt
2017-02-16  2:17       ` Byungchul Park
2017-02-16  2:31         ` Steven Rostedt [this message]
2017-02-16  2:33           ` Steven Rostedt
2017-02-16  2:41             ` Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215213150.4aa1e10d@grimm.local.home \
    --to=rostedt@goodmis.org \
    --cc=byungchul.park@lge.com \
    --cc=juri.lelli@arm.com \
    --cc=juri.lelli@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@santannapisa.it \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox