From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753209AbdBPClb (ORCPT ); Wed, 15 Feb 2017 21:41:31 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:44084 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbdBPCl3 (ORCPT ); Wed, 15 Feb 2017 21:41:29 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Thu, 16 Feb 2017 11:41:04 +0900 From: Byungchul Park To: Steven Rostedt Cc: Juri Lelli , peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com, Luca Abeni Subject: Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task() Message-ID: <20170216024104.GT16086@X58A-UD3R> References: <1487135511-15817-1-git-send-email-byungchul.park@lge.com> <20170215104749.GB1368@e106622-lin> <20170215092507.106f7964@gandalf.local.home> <20170215144503.GG1368@e106622-lin> <20170216021758.GS16086@X58A-UD3R> <20170215213150.4aa1e10d@grimm.local.home> <20170215213335.70b72c19@grimm.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215213335.70b72c19@grimm.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 09:33:35PM -0500, Steven Rostedt wrote: > On Wed, 15 Feb 2017 21:31:50 -0500 > Steven Rostedt wrote: > > > On Thu, 16 Feb 2017 11:17:58 +0900 > > Byungchul Park wrote: > > > > > > > Juri and steven, thank you very much for reviewing it. > > > > > > I'm not sure and familiar with... Should I add your 'reviewed by' into > > > my patches by myself? > > > > > > > No, it's the maintainer's job to add these tags when they take your > > patch. If you were to resend the patch because of a minor change > > (something a reviewer told you to make but still gave you their > > reviewed-by tag), then you could add it. Or if you have a patch series > > and resend a new series, you can add the reviewed-by tags to the > > patches that were not changed. But if you were to change a patch, then > > you need to ask the reviewer to give their tag again, because they need > > to review the changes made before their tag should go on it. > > > > I just noticed that you sent a v2 of the patch we reviewed. Since you > didn't change it, you could have added our review-by tags. That makes > it a bit easier for maintainers to know. I got it! Thank you very much for your kind explanation. > > -- Steve