From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Joel Fernandes <joelaf@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Subject: [PATCH] trace: Correct comments about list of pages in buffer
Date: Thu, 16 Feb 2017 02:17:28 -0800 [thread overview]
Message-ID: <20170216101728.27753-1-joelaf@google.com> (raw)
Comments related to list of pages in the ring buffer seem to be incorrect.
This patch corrects them.
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
kernel/trace/trace.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index d7449783987a..94d508c08c7e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -262,11 +262,11 @@ unsigned long long ns2usecs(u64 nsec)
/*
* The global_trace is the descriptor that holds the tracing
* buffers for the live tracing. For each CPU, it contains
- * a link list of pages that will store trace entries. The
- * page descriptor of the pages in the memory is used to hold
- * the link list by linking the lru item in the page descriptor
- * to each of the pages in the buffer per CPU.
- *
+ * a link list of pages that will store trace entries.
+ * Each page is wrapped by a buffer_page descriptor which contains
+ * a list element used to hold the list of pages by linking with
+ * other list elements of other buffer_page descriptors (for each
+ * of the pages) in the ring buffer per CPU.
* For each active CPU there is a data field that holds the
* pages for the buffer for that CPU. Each CPU has the same number
* of pages allocated for its buffer.
--
2.11.0.483.g087da7b7c-goog
next reply other threads:[~2017-02-16 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 10:17 Joel Fernandes [this message]
2017-02-16 14:33 ` [PATCH] trace: Correct comments about list of pages in buffer Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216101728.27753-1-joelaf@google.com \
--to=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox