From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932922AbdBPQjW (ORCPT ); Thu, 16 Feb 2017 11:39:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51208 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932385AbdBPQjV (ORCPT ); Thu, 16 Feb 2017 11:39:21 -0500 Date: Thu, 16 Feb 2017 08:39:19 -0800 From: Greg KH To: Oliver Neukum Cc: "Gustavo A. R. Silva" , thomas@winischhofer.net, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Message-ID: <20170216163919.GB30538@kroah.com> References: <20170208040134.GA4460@embeddedgus> <1487240929.22685.19.camel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1487240929.22685.19.camel@suse.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: > Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > > The condition modex % 16 cannot be true when modex value is equal to > > 640 > > The condition du & 0xff cannot be true when du value is equal to > > 0x1400 > >  > > Sorry for speaking up so late, but this is not a good idea. > We lose the knowledge how to do this correctly, if we want > to change the resolution. Given the age of this driver, I doubt that will ever happen :) thanks, greg k-h