From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933555AbdBPSen (ORCPT ); Thu, 16 Feb 2017 13:34:43 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58744 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932697AbdBPSem (ORCPT ); Thu, 16 Feb 2017 13:34:42 -0500 Date: Thu, 16 Feb 2017 10:34:35 -0800 From: Greg KH To: simran singhal Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] staging: rtl8192u: fixing white space issue Message-ID: <20170216183435.GA5486@kroah.com> References: <20170214200713.GA29669@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214200713.GA29669@singhal-Inspiron-5558> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 01:37:13AM +0530, simran singhal wrote: > Fix the following checkpatch.pl error and warnings: > WARNING: please, no space before tabs > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h > index 873969c..a54dfad 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h > @@ -30,7 +30,7 @@ typedef struct _TX_TS_RECORD{ > u16 TxCurSeq; > BA_RECORD TxPendingBARecord; /* For BA Originator */ > BA_RECORD TxAdmittedBARecord; /* For BA Originator */ > -/* QOS_DL_RECORD DLRecord; */ > +/* QOS_DL_RECORD DLRecord; */ Why did you change the number of tabs here? Also, just delete unused fields, why keep them around? thanks, greg k-h