From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933772AbdBPW16 (ORCPT ); Thu, 16 Feb 2017 17:27:58 -0500 Received: from gateway31.websitewelcome.com ([192.185.144.29]:11856 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933547AbdBPW14 (ORCPT ); Thu, 16 Feb 2017 17:27:56 -0500 Date: Thu, 16 Feb 2017 16:27:36 -0600 From: "Gustavo A. R. Silva" To: gregkh@linuxfoundation.org, wsa-dev@sang-engineering.com Cc: accessrunner-general@lists.sourceforge.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin , "Gustavo A. R. Silva" Subject: [PATCH] usb: atm: remove unnecessary code Message-ID: <20170216222736.GA6510@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.172.203 X-Exim-ID: 1ceUWX-000H7Y-O9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.172.203]:41038 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-CMAE-Envelope: MS4wfDMbtOK7Ivq+2mYDGLCzwlWB1LlH4wp/E0df0q+kOje3CPe4Ky8rNqm1R0mJXnYwncFpasrWHQe1jnPuADFQNZwHsLKlXUcCLCFqEVEN996GxYjImrSC jVzqwYZxxX2Qge5U+7k286mffmUKOgE1T5zntVCN+vjWpRpDU4ZeodmaPquWIabvJmMbwALws+3fmVq5DK033kTCBMGGuobGnNA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'index' is an unsigned variable, and less-than-zero comparison of an unsigned variable is never true. Addresses-Coverity-ID: 115396 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/atm/cxacru.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index f9fe86b6..d65a64c 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c @@ -474,7 +474,7 @@ static ssize_t cxacru_sysfs_store_adsl_config(struct device *dev, ret = sscanf(buf + pos, "%x=%x%n", &index, &value, &tmp); if (ret < 2) return -EINVAL; - if (index < 0 || index > 0x7f) + if (index > 0x7f) return -EINVAL; if (tmp < 0 || tmp > len - pos) return -EINVAL; -- 2.5.0