From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753622AbdBQAQq (ORCPT ); Thu, 16 Feb 2017 19:16:46 -0500 Received: from gateway33.websitewelcome.com ([192.185.145.87]:41995 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752820AbdBQAQp (ORCPT ); Thu, 16 Feb 2017 19:16:45 -0500 Date: Thu, 16 Feb 2017 18:16:40 -0600 From: "Gustavo A. R. Silva" To: mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin , "Gustavo A. R. Silva" Subject: [PATCH] usb: host: add cast to avoid potential integer overflow Message-ID: <20170217001640.GA9137@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.172.203 X-Exim-ID: 1ceWE5-000LbP-9S X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.172.203]:43246 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The type of variable 'sel' is unsigned int. Such variable is being used multiple times in a context that expects an expression of type unsigned long long. So, to avoid any potential integer overflow, a cast to type unsigned long long is added. Addresses-Coverity-ID: 703408 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/host/xhci.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 50aee8b..8094d9a 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -4298,23 +4298,23 @@ static unsigned long long xhci_calculate_intel_u1_timeout( ep_type = usb_endpoint_type(desc); switch (ep_type) { case USB_ENDPOINT_XFER_CONTROL: - timeout_ns = udev->u1_params.sel * 3; + timeout_ns = (unsigned long long)udev->u1_params.sel * 3; break; case USB_ENDPOINT_XFER_BULK: - timeout_ns = udev->u1_params.sel * 5; + timeout_ns = (unsigned long long)udev->u1_params.sel * 5; break; case USB_ENDPOINT_XFER_INT: intr_type = usb_endpoint_interrupt_type(desc); if (intr_type == USB_ENDPOINT_INTR_NOTIFICATION) { - timeout_ns = udev->u1_params.sel * 3; + timeout_ns = (unsigned long long)udev->u1_params.sel * 3; break; } /* Otherwise the calculation is the same as isoc eps */ case USB_ENDPOINT_XFER_ISOC: timeout_ns = xhci_service_interval_to_ns(desc); timeout_ns = DIV_ROUND_UP_ULL(timeout_ns * 105, 100); - if (timeout_ns < udev->u1_params.sel * 2) - timeout_ns = udev->u1_params.sel * 2; + if (timeout_ns < (unsigned long long)udev->u1_params.sel * 2) + timeout_ns = (unsigned long long)udev->u1_params.sel * 2; break; default: return 0; -- 2.5.0