From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932134AbdBQIUQ (ORCPT ); Fri, 17 Feb 2017 03:20:16 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36085 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbdBQIUN (ORCPT ); Fri, 17 Feb 2017 03:20:13 -0500 Date: Fri, 17 Feb 2017 09:20:09 +0100 From: Corentin Labbe To: Frank Rowand Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Message-ID: <20170217082009.GB22723@Red> References: <20170215142245.11207-1-clabbe.montjoie@gmail.com> <58A47521.9090909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58A47521.9090909@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 07:34:57AM -0800, Frank Rowand wrote: > On 02/15/17 06:22, Corentin Labbe wrote: > > This symbol will be needed for the dwmac-sun8i ethernet driver. > > For letting it to be build as module, of_device_compatible_match need to > > be exported. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/of/base.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/of/base.c b/drivers/of/base.c > > index df6f6e3..fba351b 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device, > > > > return score; > > } > > +EXPORT_SYMBOL(of_device_compatible_match); > > > > /** > > * of_machine_is_compatible - Test root of device tree for a given compatible value > > > > > > Rob's reply to the last person who requested that: > > It's not missing because no modules use it. It's generally preferred > to use a match table and of_match_node. > > -Frank I replace of_device_compatible_match like you said and it works. Thanks Corentin Labbe