From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932601AbdBQJOt (ORCPT ); Fri, 17 Feb 2017 04:14:49 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34429 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754564AbdBQJOp (ORCPT ); Fri, 17 Feb 2017 04:14:45 -0500 Date: Fri, 17 Feb 2017 10:14:39 +0100 From: Corentin Labbe To: Maxime Ripard Cc: peppe.cavallaro@st.com, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, alexandre.torgue@st.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins Message-ID: <20170217091439.GE22723@Red> References: <20170216124859.14346-1-clabbe.montjoie@gmail.com> <20170216124859.14346-9-clabbe.montjoie@gmail.com> <20170216190632.hezcacn3hw5uhxcn@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170216190632.hezcacn3hw5uhxcn@lukather> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 08:06:32PM +0100, Maxime Ripard wrote: > On Thu, Feb 16, 2017 at 01:48:46PM +0100, Corentin Labbe wrote: > > This patch add pinctrl node for dwmac-sun8i on H3. > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > > index 61d56d2..59ed40e 100644 > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > @@ -349,6 +349,17 @@ > > function = "i2c2"; > > }; > > > > + emac_rgmii_pins: emac0@0 { > > + allwinner,pins = "PD0", "PD1", "PD2", "PD3", > > + "PD4", "PD5", "PD7", > > + "PD8", "PD9", "PD10", > > + "PD12", "PD13", "PD15", > > + "PD16", "PD17"; > > + allwinner,function = "emac"; > > Please use the generic pin config properties (ie. pins and functions). > > > + allwinner,drive = ; > > Why do you need to use 40mA? > > > + allwinner,pull = ; > > This is the default now. > Will fix that in all DT Thanks Corentin Labbe