From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933965AbdBQNfM (ORCPT ); Fri, 17 Feb 2017 08:35:12 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33756 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933545AbdBQNfK (ORCPT ); Fri, 17 Feb 2017 08:35:10 -0500 Date: Fri, 17 Feb 2017 15:35:04 +0200 From: Krzysztof Kozlowski To: Charles Keepax Cc: linus.walleij@linaro.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data Message-ID: <20170217133504.5poemeadyunc4pyh@kozik-lap> References: <1487251636-2480-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1487251636-2480-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1487251636-2480-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 01:27:16PM +0000, Charles Keepax wrote: > Use devm_gpiochip_add_data to simplify the error path in > samsung_gpiolib_register. Additionally this would also fix a leak if > the pinctrl driver was unbound, although admittedly I can't see any > good use-case for doing so, but the driver does currently allow it. Driver does not allow unbinding (.suppress_bind_attrs = true)... Regardless of this: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof