From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934032AbdBQNoo (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Feb 2017 08:44:44 -0500
Received: from mail.kernel.org ([198.145.29.136]:35354 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933900AbdBQNon (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Feb 2017 08:44:43 -0500
Date: Fri, 17 Feb 2017 10:44:37 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] building libtraceevent with clang
Message-ID: <20170217134437.GC4109@kernel.org>
References: <20170210170317.GA14313@kernel.org>
 <20170210141408.5eeb6e91@gandalf.local.home>
 <20170213162455.GB6473@kernel.org>
 <20170213162622.GC6473@kernel.org>
 <20170213121418.47f279e8@gandalf.local.home>
 <20170213172020.GE6473@kernel.org>
 <20170216210023.5c39de2f@grimm.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170216210023.5c39de2f@grimm.local.home>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Feb 16, 2017 at 09:00:23PM -0500, Steven Rostedt escreveu:
> On Mon, 13 Feb 2017 14:20:20 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > +++ b/tools/lib/traceevent/plugin_function.c
> > @@ -130,7 +130,7 @@ static int function_handler(struct trace_seq *s, struct pevent_record *record,
> >  	unsigned long long pfunction;
> >  	const char *func;
> >  	const char *parent;
> > -	int index;
> > +	int index = 0;
 
> I went to apply this to trace-cmd's version, and it failed to apply.  Then I
> realized that I had this fixed back in 2015, but missed sending it.

> That's because I don't strictly follow the 80 column limit for some of the if
> statements (I find the break up ugly), and when doing diffs, this got lost in
> the diffs of the 80 column limits ones done with the port to the kernel tree.
> :-/

I'm not strict about it either:

$ find tools/perf/ -name "*.[ch]" | xargs cat | wc -l
161984
$ find tools/perf/ -name "*.[ch]" | xargs expand | cut -c80- | grep -v ^$ | wc -l
3706
$ 

2.29%

You (well, libtracevent) are a bit more strict:

$ find tools/lib/traceevent/ -name "*.[ch]" | xargs cat | wc -l
13814
$ find tools/lib/traceevent/ -name "*.[ch]" | xargs expand | cut -c80- | grep -v ^$ | wc -l
184
$ 

1.33%

For reference, the whole kernel, modulo tools/

$ find . -name "*.[ch]" | grep -v ^\.\/tools | xargs cat | wc -l
20162880
$ find . -name "*.[ch]" | grep -v ^\.\/tools | xargs expand | cut -c80- | grep -v ^$ | wc -l
439722
$

2.18%

Using functions to avoid too deep if statements usually helps here tho :-)

- Arnaldo
 
> -- Steve
> 
> 
> >  
> >  	if (pevent_get_field_val(s, event, "ip", record, &function, 1))
> >  		return trace_seq_putc(s, '!');
> >