From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934035AbdBQOAC (ORCPT ); Fri, 17 Feb 2017 09:00:02 -0500 Received: from foss.arm.com ([217.140.101.70]:54910 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933832AbdBQOAB (ORCPT ); Fri, 17 Feb 2017 09:00:01 -0500 Date: Fri, 17 Feb 2017 14:00:01 +0000 From: Will Deacon To: Alexander Shishkin Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, kim.phillips@arm.com, alex.bennee@linaro.org, christoffer.dall@linaro.org, tglx@linutronix.de, peterz@infradead.org, robh@kernel.org, suzuki.poulose@arm.com, pawel.moll@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Message-ID: <20170217140001.GD15431@arm.com> References: <1485540470-11469-1-git-send-email-will.deacon@arm.com> <1485540470-11469-8-git-send-email-will.deacon@arm.com> <8737fdj5q0.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8737fdj5q0.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote: > Will Deacon writes: > > > @@ -485,7 +485,8 @@ int intel_bts_interrupt(void) > > return handled; > > > > perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0), > > - !!local_xchg(&buf->lost, 0)); > > + local_xchg(&buf->lost, 0) ? > > + PERF_AUX_FLAG_OVERWRITE : 0); > > Heh, this one would have taken some time to debug. :) Don't worry, this isn't a bug fix! This patch changes the prototype for perf_aux_output_end so that it takes the flag instead of a "bool truncated" parameter, so this is just fixing up the callers at the same time. Will