From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934336AbdBQOoG (ORCPT ); Fri, 17 Feb 2017 09:44:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934351AbdBQOoC (ORCPT ); Fri, 17 Feb 2017 09:44:02 -0500 Date: Fri, 17 Feb 2017 15:43:59 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , David Ahern , Namhyung Kim , Peter Zijlstra , Borislav Petkov , lkml , Ingo Molnar Subject: Re: [PATCH 4/5] perf stat: Add -a as a default target Message-ID: <20170217144359.GA11692@krava> References: <1487340058-10496-1-git-send-email-jolsa@kernel.org> <1487340058-10496-5-git-send-email-jolsa@kernel.org> <20170217142747.GD4109@kernel.org> <20170217143327.GA11281@krava> <20170217144128.GF4109@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217144128.GF4109@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 17 Feb 2017 14:44:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 11:41:28AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 17, 2017 at 03:33:27PM +0100, Jiri Olsa escreveu: > > On Fri, Feb 17, 2017 at 11:27:47AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Fri, Feb 17, 2017 at 03:00:57PM +0100, Jiri Olsa escreveu: > > > > Boris asked for default -a option in case we monitor > > > > only uncore events. While implementing that I thought > > > > it might be actually useful to make it overall default. > > > > > # perf stat > > > > Warning: No target specified, setting system-wide collection (-a). > > > > Humm, would be interesting to disable this after a few warnings? Just > > > one? > > > not sure it's good idea to keep the count of that somewhere.. > > how about i make the warning smaller ;-) > > > # perf stat > > Forced system wide target. > > ... > > > > BTW, this is how 'perf trace' works since day one, i.e. no target means > > > system wide syscall tracing. > > > or we could omit the warning completely as probably perf trace does > > I think that we should have some note on the Documentation (have you > added it?) and be done with it. > > Another thing possiblity my mind, print that at the end? like: > > perf record > ^C[ perf record: Woken up 1 times to write data - system wide samples ] > [ perf record: Captured and wrote 1.738 MB perf.data (7565 samples) ] > > ---------- > > Then people will thing, hey, so now it does systemwide samples when I > pass no target, I don't have anymore to type _three_ keys! cool! :-) ok, I'll check on that and send new version for the last 2 patches thanks, jirka